Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/trixbox_langchoice.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'        => 'Trixbox langChoice PHP Local File Inclusion',
      'Description' => %q{
          This module injects php into the trixbox session file and then, in a second call, evaluates
Severity: Minor
Found in modules/exploits/unix/webapp/trixbox_langchoice.rb - About 1 hr to fix

    Method check has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    # We need to ensure that this can be reached via POST
    uri = normalize_uri(datastore['URI'])
    target_code = 200
    Severity: Minor
    Found in modules/exploits/unix/webapp/trixbox_langchoice.rb - About 1 hr to fix

      Method exploit has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def exploit
    # We will be be passing this our langChoice values
    uri = normalize_uri(datastore['URI'])

    # Prepare PHP file contents
      Severity: Minor
      Found in modules/exploits/unix/webapp/trixbox_langchoice.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    # We need to ensure that this can be reached via POST
    uri = normalize_uri(datastore['URI'])
    target_code = 200
        Severity: Minor
        Found in modules/exploits/unix/webapp/trixbox_langchoice.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return Exploit::CheckCode::Safe
        Severity: Major
        Found in modules/exploits/unix/webapp/trixbox_langchoice.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return Exploit::CheckCode::Appears
          Severity: Major
          Found in modules/exploits/unix/webapp/trixbox_langchoice.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return Exploit::CheckCode::Detected
            Severity: Major
            Found in modules/exploits/unix/webapp/trixbox_langchoice.rb - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status