Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/webmin_show_cgi_exec.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method initialize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Webmin /file/show.cgi Remote Command Execution',
      'Description'    => %q{
          This module exploits an arbitrary command execution vulnerability in Webmin
Severity: Minor
Found in modules/exploits/unix/webapp/webmin_show_cgi_exec.rb - About 1 hr to fix

    Method exploit has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit

    peer = "#{rhost}:#{rport}"

    print_status("Attempting to login...")
    Severity: Minor
    Found in modules/exploits/unix/webapp/webmin_show_cgi_exec.rb - About 1 hr to fix

      Method check has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check

    peer = "#{rhost}:#{rport}"

    vprint_status("Attempting to login...")
      Severity: Minor
      Found in modules/exploits/unix/webapp/webmin_show_cgi_exec.rb - About 1 hr to fix

        Method exploit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit

    peer = "#{rhost}:#{rport}"

    print_status("Attempting to login...")
        Severity: Minor
        Found in modules/exploits/unix/webapp/webmin_show_cgi_exec.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def check

    peer = "#{rhost}:#{rport}"

    vprint_status("Attempting to login...")
        Severity: Minor
        Found in modules/exploits/unix/webapp/webmin_show_cgi_exec.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status