Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/zoneminder_packagecontrol_exec.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info,
      'Name'           => 'ZoneMinder Video Server packageControl Command Execution',
      'Description'    => %q{
        This module exploits a command execution vulnerability in ZoneMinder Video
Severity: Minor
Found in modules/exploits/unix/webapp/zoneminder_packagecontrol_exec.rb - About 1 hr to fix

    Method exploit has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    base     = target_uri.path
    base    << '/' if base[-1, 1] != '/'
    cookie   = "ZMSESSID=" + rand_text_alphanumeric(rand(10)+6)
    user     = datastore['USERNAME']
    Severity: Minor
    Found in modules/exploits/unix/webapp/zoneminder_packagecontrol_exec.rb - About 1 hr to fix

      Method check has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check

    peer    = "#{rhost}:#{rport}"
    base    = target_uri.path
    base    << '/' if base[-1, 1] != '/'
      Severity: Minor
      Found in modules/exploits/unix/webapp/zoneminder_packagecontrol_exec.rb - About 1 hr to fix

        Method exploit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    base     = target_uri.path
    base    << '/' if base[-1, 1] != '/'
    cookie   = "ZMSESSID=" + rand_text_alphanumeric(rand(10)+6)
    user     = datastore['USERNAME']
        Severity: Minor
        Found in modules/exploits/unix/webapp/zoneminder_packagecontrol_exec.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def check

    peer    = "#{rhost}:#{rport}"
    base    = target_uri.path
    base    << '/' if base[-1, 1] != '/'
        Severity: Minor
        Found in modules/exploits/unix/webapp/zoneminder_packagecontrol_exec.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return Exploit::CheckCode::Safe
        Severity: Major
        Found in modules/exploits/unix/webapp/zoneminder_packagecontrol_exec.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status