Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/adobe_flash_otf_font.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info,
      'Name'           => "Adobe Flash Player 11.3 Kern Table Parsing Integer Overflow",
      'Description'    => %q{
          This module exploits a vulnerability found in the ActiveX component of Adobe
Severity: Major
Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 2 hrs to fix

    Method get_payload has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_payload(t, flash_version=nil)
    if t['Rop'].nil?
      p = [
        0x0c0c0c0c, # mapped at 1e0d0000
        0x0c0c0c0c,
    Severity: Minor
    Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 1 hr to fix

      Method on_request_uri has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)
    agent = request.headers['User-Agent']
    my_target = get_target(agent)

    # Avoid the attack if the victim doesn't have the same setup we're targeting
      Severity: Minor
      Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 1 hr to fix

        Method get_target has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    if agent =~ /NT 5\.1/ and agent =~ /MSIE 6/
        Severity: Minor
        Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_payload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_payload(t, flash_version=nil)
    if t['Rop'].nil?
      p = [
        0x0c0c0c0c, # mapped at 1e0d0000
        0x0c0c0c0c,
        Severity: Minor
        Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return targets[5]  #IE 8 on Windows 7 SP1
        Severity: Major
        Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return targets[4]  #IE 7 on Windows Vista SP2
          Severity: Major
          Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return targets[6]  #IE 9 on Windows 7 SP1
            Severity: Major
            Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return nil
              Severity: Major
              Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb - About 30 mins to fix

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    if agent =~ /NT 5\.1/ and agent =~ /MSIE 6/
                Severity: Major
                Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb and 4 other locations - About 2 hrs to fix
                modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb on lines 345..363
                modules/exploits/windows/browser/hp_alm_xgo_setshapenodetype_exec.rb on lines 80..98
                modules/exploits/windows/browser/msxml_get_definition_code_exec.rb on lines 131..149
                modules/exploits/windows/browser/oracle_autovue_setmarkupmode.rb on lines 309..327

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 83.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                  def create_swf
    path = ::File.join( Msf::Config.data_directory, "exploits", "CVE-2012-1535", "Main.swf" )
    fd = ::File.open( path, "rb" )
    swf = fd.read(fd.stat.size)
    fd.close
                Severity: Minor
                Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb and 2 other locations - About 15 mins to fix
                modules/exploits/windows/browser/ms11_093_ole32.rb on lines 174..179
                modules/exploits/windows/browser/ms14_012_cmarkup_uaf.rb on lines 75..80

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 31 locations. Consider refactoring.
                Open

                          [ 'CVE', '2012-1535' ],
          [ 'OSVDB', '84607'],
          [ 'BID', '55009'],
          [ 'URL', 'http://labs.alienvault.com/labs/index.php/2012/cve-2012-1535-adobe-flash-being-exploited-in-the-wild/' ],
          [ 'URL', 'https://developer.apple.com/fonts/TTRefMan/RM06/Chap6.html' ],
                Severity: Major
                Found in modules/exploits/windows/browser/adobe_flash_otf_font.rb and 30 other locations - About 15 mins to fix
                modules/auxiliary/admin/http/cisco_ios_xe_os_exec_cve_2023_20273.rb on lines 54..65
                modules/auxiliary/dos/windows/rdp/ms12_020_maxchannelids.rb on lines 22..29
                modules/auxiliary/scanner/ssh/ssh_enumusers.rb on lines 37..44
                modules/exploits/android/browser/stagefright_mp4_tx3g_64bit.rb on lines 53..61
                modules/exploits/freebsd/local/ip6_setpktopt_uaf_priv_esc.rb on lines 48..55
                modules/exploits/linux/http/fritzbox_echo_exec.rb on lines 31..38
                modules/exploits/linux/http/klog_server_authenticate_user_unauth_command_injection.rb on lines 40..47
                modules/exploits/linux/http/vmware_vcenter_vsan_health_rce.rb on lines 32..40
                modules/exploits/linux/local/af_packet_packet_set_ring_priv_esc.rb on lines 61..68
                modules/exploits/linux/local/blueman_set_dhcp_handler_dbus_priv_esc.rb on lines 39..46
                modules/exploits/linux/local/ptrace_sudo_token_priv_esc.rb on lines 43..50
                modules/exploits/linux/local/rds_rds_page_copy_user_priv_esc.rb on lines 48..55
                modules/exploits/linux/local/servu_ftp_server_prepareinstallation_priv_esc.rb on lines 41..48
                modules/exploits/linux/local/sudoedit_bypass_priv_esc.rb on lines 47..54
                modules/exploits/multi/browser/java_atomicreferencearray.rb on lines 35..42
                modules/exploits/multi/browser/java_jre17_jmxbean_2.rb on lines 35..42
                modules/exploits/multi/browser/java_verifier_field_access.rb on lines 35..42
                modules/exploits/multi/http/hp_sitescope_uploadfileshandler.rb on lines 34..41
                modules/exploits/multi/http/struts2_multi_eval_ognl.rb on lines 33..40
                modules/exploits/multi/http/vmware_vcenter_uploadova_rce.rb on lines 43..50
                modules/exploits/unix/dhcp/rhel_dhcp_client_command_injection.rb on lines 35..42
                modules/exploits/unix/fileformat/imagemagick_delegate.rb on lines 39..46
                modules/exploits/unix/webapp/vicidial_manager_send_cmd_exec.rb on lines 37..44
                modules/exploits/windows/browser/adobe_flash_regex_value.rb on lines 33..40
                modules/exploits/windows/browser/adobe_flashplayer_flash10o.rb on lines 30..37
                modules/exploits/windows/browser/java_docbase_bof.rb on lines 46..53
                modules/exploits/windows/browser/mozilla_firefox_onreadystatechange.rb on lines 32..39
                modules/exploits/windows/browser/ms06_013_createtextrange.rb on lines 34..41
                modules/exploits/windows/fileformat/winamp_maki_bof.rb on lines 33..40
                modules/exploits/windows/local/ms15_078_atmfd_bof.rb on lines 64..71

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 25.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status