rapid7/metasploit-framework

Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Adobe Collab.getIcon() Buffer Overflow',
      'Description'    => %q{
          This module exploits a buffer overflow in Adobe Reader and Adobe Acrobat.

Method make_pdf has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def make_pdf(js)

    xref = []
    eol = "\x0d\x0a"
    endobj = "endobj" << eol

Method on_request_uri has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def on_request_uri(cli, request)
    return if ((p = regenerate_payload(cli)) == nil)
    # Encode the shellcode.
    shellcode = Rex::Text.to_unescape(payload.encoded, Rex::Arch.endian(target.arch))

Identical blocks of code found in 6 locations. Consider refactoring.

Open

  def make_pdf(js)

    xref = []
    eol = "\x0d\x0a"
    endobj = "endobj" << eol

• Read up
  Read up

Identical blocks of code found in 20 locations. Consider refactoring.

Open

  def n_obfu(str)
    result = ""
    str.scan(/./u) do |c|
      if rand(2) == 0 and c.upcase >= 'A' and c.upcase <= 'Z'
        result << "#%x" % c.unpack("C*")[0]

• Read up
  Read up

Identical blocks of code found in 22 locations. Consider refactoring.

Open

  def ascii_hex_whitespace_encode(str)
    result = ""
    whitespace = ""
    str.each_byte do |b|
      result << whitespace << "%02x" % b

• Read up
  Read up