Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/apple_quicktime_texml_font_table.rb

Summary

Maintainability
C
1 day
Test Coverage

Method on_request_uri has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def on_request_uri(client, request)

    return if ((p = regenerate_payload(client)) == nil)

    agent = request.headers['User-Agent']
Severity: Major
Found in modules/exploits/windows/browser/apple_quicktime_texml_font_table.rb - About 5 hrs to fix

    Method on_request_uri has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def on_request_uri(client, request)

    return if ((p = regenerate_payload(client)) == nil)

    agent = request.headers['User-Agent']
    Severity: Minor
    Found in modules/exploits/windows/browser/apple_quicktime_texml_font_table.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Apple QuickTime 7.7.2 TeXML Style Element font-table Field Stack Buffer Overflow',
      'Description'    => %q{
          This module exploits a vulnerability found in Apple QuickTime. When handling
    Severity: Minor
    Found in modules/exploits/windows/browser/apple_quicktime_texml_font_table.rb - About 1 hr to fix

      Method get_target has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
      Severity: Minor
      Found in modules/exploits/windows/browser/apple_quicktime_texml_font_table.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_target has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    nt = agent.scan(/Windows NT (\d\.\d)/).flatten[0] || ''
      Severity: Minor
      Found in modules/exploits/windows/browser/apple_quicktime_texml_font_table.rb - About 1 hr to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

              content << <<-ENDEMBED
<OBJECT
CLASSID="clsid:02BF25D5-8C17-4B23-BC80-D3488ABDDC6B"
WIDTH="1"
HEIGHT="1"
        Severity: Minor
        Found in modules/exploits/windows/browser/apple_quicktime_texml_font_table.rb and 4 other locations - About 20 mins to fix
        lib/msf/core/auxiliary/pii.rb on lines 98..98
        modules/exploits/windows/browser/apple_quicktime_mime_type.rb on lines 193..205
        modules/exploits/windows/browser/apple_quicktime_rtsp.rb on lines 104..116
        modules/exploits/windows/browser/apple_quicktime_smil_debug.rb on lines 124..136

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status