Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb

Summary

Maintainability
D
2 days
Test Coverage

Method initialize has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Cisco Linksys PlayerPT ActiveX Control SetSource sURL Argument Buffer Overflow',
      'Description'    => %q{
          This module exploits a vulnerability found in Cisco Linksys PlayerPT 1.0.0.15
Severity: Major
Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 4 hrs to fix

    File cisco_playerpt_setsource_surl.rb has 348 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = NormalRanking

  include Msf::Exploit::Remote::HttpServer::HTML
  include Msf::Exploit::Remote::Seh
    Severity: Minor
    Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 4 hrs to fix

      Method on_request_uri has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)

    agent = request.headers['User-Agent']
    print_status("User-agent: #{agent}")
      Severity: Major
      Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 2 hrs to fix

        Method get_rop_chain has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def get_rop_chain(t)

    # Both ROP chains generated by mona.py - See corelan.be
    case t['Rop']
      when :msvcrt
        Severity: Minor
        Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 1 hr to fix

          Method get_random_spray has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def get_random_spray(t, js_rop, js_code, js_90_nops)

    spray = <<-JS

    function randomblock(blocksize)
          Severity: Minor
          Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 1 hr to fix

            Method get_target has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    if agent =~ /NT 5\.1/ and agent =~ /MSIE 6/
            Severity: Minor
            Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get_aligned_spray has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def get_aligned_spray(t, js_rop, js_code, js_nops, js_90_nops)
            Severity: Minor
            Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 35 mins to fix

              Method on_request_uri has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def on_request_uri(cli, request)

    agent = request.headers['User-Agent']
    print_status("User-agent: #{agent}")
              Severity: Minor
              Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                    return targets[6]  #IE 9 on Windows 7 SP1
              Severity: Major
              Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return nil
                Severity: Major
                Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return targets[3]  #IE 8 on Windows XP SP3
                  Severity: Major
                  Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return targets[5]  #IE 8 on Windows 7 SP1/Vista SP2
                    Severity: Major
                    Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb - About 30 mins to fix

                      Similar blocks of code found in 5 locations. Consider refactoring.
                      Open

                        def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    if agent =~ /NT 5\.1/ and agent =~ /MSIE 6/
                      Severity: Major
                      Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb and 4 other locations - About 2 hrs to fix
                      modules/exploits/windows/browser/adobe_flash_otf_font.rb on lines 133..151
                      modules/exploits/windows/browser/hp_alm_xgo_setshapenodetype_exec.rb on lines 80..98
                      modules/exploits/windows/browser/msxml_get_definition_code_exec.rb on lines 131..149
                      modules/exploits/windows/browser/oracle_autovue_setmarkupmode.rb on lines 309..327

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 83.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        def get_easy_spray(t, js_code, js_nops)
    randnop = rand_text_alpha(rand(100) + 1)

    spray = <<-JS
    var heap_obj = new heapLib.ie(0x20000);
                      Severity: Minor
                      Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb and 1 other location - About 35 mins to fix
                      modules/exploits/windows/browser/cisco_playerpt_setsource.rb on lines 106..130

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 34.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if my_target['RandomHeap']
      js = get_random_spray(my_target, js_rop, js_code, js_90_nops)
    elsif not my_target['Rop'].nil?
      js = get_aligned_spray(my_target, js_rop, js_code, js_nops, js_90_nops)
    else
                      Severity: Minor
                      Found in modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb and 1 other location - About 20 mins to fix
                      modules/exploits/windows/browser/msxml_get_definition_code_exec.rb on lines 338..344

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 28.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status