Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/foxit_reader_plugin_url_bof.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info,
      'Name'           => "Foxit Reader Plugin URL Processing Buffer Overflow",
      'Description'    => %q{
          This module exploits a vulnerability in the Foxit Reader Plugin, it exists in
Severity: Minor
Found in modules/exploits/windows/browser/foxit_reader_plugin_url_bof.rb - About 2 hrs to fix

    Method on_request_uri has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def on_request_uri(cli, request)

    agent = request.headers['User-Agent']
    my_target = get_target(agent)
    Severity: Minor
    Found in modules/exploits/windows/browser/foxit_reader_plugin_url_bof.rb - About 1 hr to fix

      Method on_request_uri has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)

    agent = request.headers['User-Agent']
    my_target = get_target(agent)
      Severity: Minor
      Found in modules/exploits/windows/browser/foxit_reader_plugin_url_bof.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method win7_rop_chain has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def win7_rop_chain

    # rop chain generated with mona.py - www.corelan.be
    rop_gadgets =
      [
      Severity: Minor
      Found in modules/exploits/windows/browser/foxit_reader_plugin_url_bof.rb - About 1 hr to fix

        Method get_target has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    #Mozilla/5.0 (Windows NT 6.1; rv:18.0) Gecko/20100101 Firefox/18.0
        Severity: Minor
        Found in modules/exploits/windows/browser/foxit_reader_plugin_url_bof.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status