Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/hp_alm_xgo_setshapenodetype_exec.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  def ie_heap_spray(my_target, p)
    js_code = Rex::Text.to_unescape(p, Rex::Arch.endian(target.arch))
    js_nops = Rex::Text.to_unescape("\x0c"*4, Rex::Arch.endian(target.arch))
    js_random_nops = Rex::Text.to_unescape(make_nops(4), Rex::Arch.endian(my_target.arch))
    randnop = rand_text_alpha(rand(100) + 1)
Severity: Major
Found in modules/exploits/windows/browser/hp_alm_xgo_setshapenodetype_exec.rb and 5 other locations - About 3 hrs to fix
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 110..186
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 111..187
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 116..192
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 111..187
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 114..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    if agent =~ /NT 5\.1/ and agent =~ /MSIE 7/
Severity: Major
Found in modules/exploits/windows/browser/hp_alm_xgo_setshapenodetype_exec.rb and 4 other locations - About 2 hrs to fix
modules/exploits/windows/browser/adobe_flash_otf_font.rb on lines 133..151
modules/exploits/windows/browser/cisco_playerpt_setsource_surl.rb on lines 345..363
modules/exploits/windows/browser/msxml_get_definition_code_exec.rb on lines 131..149
modules/exploits/windows/browser/oracle_autovue_setmarkupmode.rb on lines 309..327

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          [ 'Automatic', {} ],
          [ 'IE 7 on Windows XP SP3', { 'Rop' => nil,     'Offset' => '0x5f4' } ],
          [ 'IE 8 on Windows XP SP3', { 'Rop' => :jre,    'Offset' => '0x5f4' } ],
          [ 'IE 7 on Windows Vista',  { 'Rop' => nil,     'Offset' => '0x5f4' } ],
          [ 'IE 8 on Windows Vista',  { 'Rop' => :jre,    'Offset' => '0x5f4' } ],
Severity: Minor
Found in modules/exploits/windows/browser/hp_alm_xgo_setshapenodetype_exec.rb and 1 other location - About 55 mins to fix
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 63..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

  def on_request_uri(cli, request)
    agent = request.headers['User-Agent']
    uri   = request.uri
    print_status("Requesting: #{uri}")
Severity: Major
Found in modules/exploits/windows/browser/hp_alm_xgo_setshapenodetype_exec.rb and 11 other locations - About 55 mins to fix
modules/exploits/windows/browser/crystal_reports_printcontrol.rb on lines 295..311
modules/exploits/windows/browser/hp_loadrunner_writefilebinary.rb on lines 238..254
modules/exploits/windows/browser/ibm_spss_c1sizer.rb on lines 364..380
modules/exploits/windows/browser/ie_cbutton_uaf.rb on lines 233..249
modules/exploits/windows/browser/ie_cgenericelement_uaf.rb on lines 215..230
modules/exploits/windows/browser/indusoft_issymbol_internationalseparator.rb on lines 266..282
modules/exploits/windows/browser/inotes_dwa85w_bof.rb on lines 271..287
modules/exploits/windows/browser/ms11_081_option.rb on lines 220..236
modules/exploits/windows/browser/ms13_009_ie_slayoutrun_uaf.rb on lines 181..197
modules/exploits/windows/browser/novell_groupwise_gwcls1_actvx.rb on lines 259..275
modules/exploits/windows/browser/quickr_qp2_bof.rb on lines 248..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status