Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/ms07_017_ani_loadimage_chunksize.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if agent =~ /Windows NT 6\.0/
          target = targets[3]   # IE7 on Vista
        elsif agent =~ /MSIE 7\.0/
          target = targets[2]   # IE7 on XP and 2003
        elsif agent =~ /MSIE 6\.0/
Severity: Minor
Found in modules/exploits/windows/browser/ms07_017_ani_loadimage_chunksize.rb and 1 other location - About 25 mins to fix
modules/exploits/windows/browser/ms07_017_ani_loadimage_chunksize.rb on lines 167..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if agent =~ /(Windows NT 6\.0|MiniRedir\/6\.0)/
          target = targets[3]   # Firefox on Vista
        elsif agent =~ /(Windows NT 5\.1|MiniRedir\/5\.1)/
          target = targets[4]   # Firefox on XP
        elsif agent =~ /(Windows NT 5\.2|MiniRedir\/5\.2)/
Severity: Minor
Found in modules/exploits/windows/browser/ms07_017_ani_loadimage_chunksize.rb and 1 other location - About 25 mins to fix
modules/exploits/windows/browser/ms07_017_ani_loadimage_chunksize.rb on lines 184..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      "\x74\x0A" +                  # jz jmp_esi            2000, XP, 2003 before MS05-002
      "\x81\x3B\x01\x00\x00\x00" +  # cmp dword [ebx], 0x1
      "\x74\x02" +                  # jz jmp_esi            NT before MS05-002
      "\x89\xDE" +                  # mov esi, ebx          all versions after MS05-002
    # jmp_esi:
Severity: Minor
Found in modules/exploits/windows/browser/ms07_017_ani_loadimage_chunksize.rb and 1 other location - About 15 mins to fix
modules/exploits/solaris/telnet/ttyprompt.rb on lines 63..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def random_whitespace
    len = rand(100)+2
    set = "\x09\x20\x0d\x0a"
    buf = ''
Severity: Minor
Found in modules/exploits/windows/browser/ms07_017_ani_loadimage_chunksize.rb and 1 other location - About 15 mins to fix
modules/exploits/windows/email/ms07_017_ani_loadimage_chunksize.rb on lines 321..330

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status