Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb

Summary

Maintainability
F
3 days
Test Coverage

Method process_propfind has 218 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def process_propfind(cli, request)
    path = request.uri
    print_status("Received WebDAV PROPFIND request for #{path}")
    body = ''
Severity: Major
Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb - About 1 day to fix

    File ms10_046_shortcut_icon_dllloader.rb has 375 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  #
  # This module acts as an HTTP server
    Severity: Minor
    Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb - About 5 hrs to fix

      Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(info,
      'Name'            => 'Microsoft Windows Shell LNK Code Execution',
      'Description'    => %q{
          This module exploits a vulnerability in the handling of Windows
      Severity: Minor
      Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb - About 1 hr to fix

        Method process_propfind has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def process_propfind(cli, request)
    path = request.uri
    print_status("Received WebDAV PROPFIND request for #{path}")
    body = ''
        Severity: Minor
        Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generate_link has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def generate_link(unc)
    uni_unc = unc.unpack("C*").pack("v*")
    path = ''
    path << [
      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x6a, 0x00, 0x00, 0x00, 0x00,
        Severity: Minor
        Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb - About 1 hr to fix

          Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def exploit

    unc = "\\\\"
    if (datastore['UNCHOST'])
      unc << datastore['UNCHOST'].dup
          Severity: Minor
          Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method process_get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def process_get(cli, request)

    myhost = (datastore['SRVHOST'] == '0.0.0.0') ? Rex::Socket.source_address(cli.peerhost) : datastore['SRVHOST']
    webdav = "\\\\#{myhost}\\"
          Severity: Minor
          Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

            def generate_link(unc)
    uni_unc = unc.unpack("C*").pack("v*")
    path = ''
    path << [
      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x6a, 0x00, 0x00, 0x00, 0x00,
          Severity: Major
          Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb and 3 other locations - About 7 hrs to fix
          modules/exploits/windows/fileformat/ms15_020_shortcut_icon_dllloader.rb on lines 115..158
          modules/exploits/windows/smb/ms10_046_shortcut_icon_dllloader.rb on lines 80..122
          modules/exploits/windows/smb/ms15_020_shortcut_icon_dllloader.rb on lines 93..135

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 230.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

              if path !~ /\/$/

      if path.index(".")
        print_status("Sending 404 for #{path} ...")
        resp = create_response(404, "Not Found")
          Severity: Major
          Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb and 4 other locations - About 1 hr to fix
          modules/exploits/windows/email/ms10_045_outlook_ref_only.rb on lines 190..205
          modules/exploits/windows/email/ms10_045_outlook_ref_resolve.rb on lines 186..201
          modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 127..141
          modules/exploits/windows/misc/wireshark_lua.rb on lines 129..143

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              if path =~ /\.lnk$/i
      # Response for the DLL
      print_status("Sending DLL multistatus for #{path} ...")
      body = %Q|<?xml version="1.0" encoding="utf-8"?>
<D:multistatus xmlns:D="DAV:" xmlns:b="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/">
          Severity: Major
          Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb and 3 other locations - About 55 mins to fix
          modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb on lines 142..181
          modules/exploits/windows/email/ms10_045_outlook_ref_only.rb on lines 149..188
          modules/exploits/windows/email/ms10_045_outlook_ref_resolve.rb on lines 145..184

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              if path =~ /\.dll$/i
      # Response for the DLL
      print_status("Sending DLL multistatus for #{path} ...")
      body = %Q|<?xml version="1.0" encoding="utf-8"?>
<D:multistatus xmlns:D="DAV:" xmlns:b="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/">
          Severity: Major
          Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb and 3 other locations - About 55 mins to fix
          modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb on lines 183..222
          modules/exploits/windows/email/ms10_045_outlook_ref_only.rb on lines 149..188
          modules/exploits/windows/email/ms10_045_outlook_ref_resolve.rb on lines 145..184

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

            def on_request_uri(cli, request)

    case request.method
    when 'OPTIONS'
      process_options(cli, request)
          Severity: Major
          Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb and 2 other locations - About 50 mins to fix
          modules/exploits/windows/email/ms10_045_outlook_ref_only.rb on lines 81..95
          modules/exploits/windows/email/ms10_045_outlook_ref_resolve.rb on lines 77..91

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 43.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def process_options(cli, request)
    print_status("Responding to WebDAV OPTIONS request")
    headers = {
      'MS-Author-Via' => 'DAV',
#            'DASL'          => '<DAV:sql>',
          Severity: Minor
          Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb and 1 other location - About 15 mins to fix
          modules/exploits/windows/email/ms10_045_outlook_ref_resolve.rb on lines 119..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status