Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/ms16_051_vbscript.rb

Summary

Maintainability
D
2 days
Test Coverage

Method exploit_html has 217 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit_html(req_uri)
    srvhost = datastore['SRVHOST']
    srvport = datastore['SRVPORT']

    template = <<-EOF
Severity: Major
Found in modules/exploits/windows/browser/ms16_051_vbscript.rb - About 1 day to fix

    File ms16_051_vbscript.rb has 396 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = NormalRanking

  include Msf::Exploit::Remote::HttpServer
  include Msf::Exploit::EXE
    Severity: Minor
    Found in modules/exploits/windows/browser/ms16_051_vbscript.rb - About 5 hrs to fix

      Method stage2_html has 109 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def stage2_html(req_uri)

    template = <<-EOF
    <html>
    <head>
      Severity: Major
      Found in modules/exploits/windows/browser/ms16_051_vbscript.rb - About 4 hrs to fix

        Method on_request_uri has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def on_request_uri(cli, request)
    # used for some debugging stuff
    ies = @ieshell
    ls  = @localsrv
    pm  = @pm_escape_html
        Severity: Minor
        Found in modules/exploits/windows/browser/ms16_051_vbscript.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status