Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/tom_sawyer_tsgetx71ex552.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info,
      'Name'           => "Tom Sawyer Software GET Extension Factory Remote Code Execution",
      'Description'    => %q{
          This module exploits a remote code execution vulnerability in the tsgetx71ex553.dll
Severity: Major
Found in modules/exploits/windows/browser/tom_sawyer_tsgetx71ex552.rb - About 3 hrs to fix

    Method on_request_uri has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def on_request_uri(cli, request)
    agent = request.headers['User-Agent']
    my_target = get_target(agent)

    # Avoid the attack if the victim doesn't have the same setup we're targeting
    Severity: Major
    Found in modules/exploits/windows/browser/tom_sawyer_tsgetx71ex552.rb - About 2 hrs to fix

      Method get_rop_chain has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_rop_chain(t)

    adjust =
    [
      junk,  # heap sprayed to 342d1ea0
      Severity: Minor
      Found in modules/exploits/windows/browser/tom_sawyer_tsgetx71ex552.rb - About 1 hr to fix

        Method get_target has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    if agent =~ /NT 5\.1/ and agent =~ /MSIE 6/
        Severity: Minor
        Found in modules/exploits/windows/browser/tom_sawyer_tsgetx71ex552.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return nil
        Severity: Major
        Found in modules/exploits/windows/browser/tom_sawyer_tsgetx71ex552.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return targets[4]  #IE 8 on Windows 7 SP1
          Severity: Major
          Found in modules/exploits/windows/browser/tom_sawyer_tsgetx71ex552.rb - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def get_target(agent)
    #If the user is already specified by the user, we'll just use that
    return target if target.name != 'Automatic'

    if agent =~ /NT 5\.1/ and agent =~ /MSIE 6/
            Severity: Major
            Found in modules/exploits/windows/browser/tom_sawyer_tsgetx71ex552.rb and 1 other location - About 1 hr to fix
            modules/exploits/windows/browser/cisco_playerpt_setsource.rb on lines 187..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status