Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/fileformat/ms09_067_excel_featheader.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'MS09-067 Microsoft Excel Malformed FEATHEADER Record Vulnerability',
      'Description'    => %q{
            This module exploits a vulnerability in the handling of the FEATHEADER record
Severity: Major
Found in modules/exploits/windows/fileformat/ms09_067_excel_featheader.rb - About 2 hrs to fix

    Method exploit has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit

    # build the Workbook stream
    ptr1 = target['ObjPtr']
    ptr2 = ptr1 + 4
    Severity: Minor
    Found in modules/exploits/windows/fileformat/ms09_067_excel_featheader.rb - About 1 hr to fix

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

                [ 'Microsoft Office 2002 (XP) SP3 base English on Windows XP SP3 English',
            { 'ObjPtr' => 0x307ddd10 }
          ],

          # Office v10.6854.6845, excel.exe v10.0.6854.0
      Severity: Minor
      Found in modules/exploits/windows/fileformat/ms09_067_excel_featheader.rb and 6 other locations - About 15 mins to fix
      modules/exploits/windows/ftp/netterm_netftpd_user.rb on lines 40..68
      modules/exploits/windows/http/maxdb_webdbm_get_overflow.rb on lines 45..49
      modules/exploits/windows/http/psoproxy91_overflow.rb on lines 42..46
      modules/exploits/windows/http/savant_31_overflow.rb on lines 55..59
      modules/exploits/windows/license/sentinel_lm7_udp.rb on lines 43..47
      modules/exploits/windows/proxy/ccproxy_telnet_ping.rb on lines 44..48

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status