Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/fileformat/ms12_005.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info,
      'Name'           => "MS12-005 Microsoft Office ClickOnce Unsafe Object Package Handling Vulnerability",
      'Description'    => %q{
          This module exploits a vulnerability found in Microsoft Office's ClickOnce
Severity: Minor
Found in modules/exploits/windows/fileformat/ms12_005.rb - About 1 hr to fix

    Method get_download_exec_payload has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_download_exec_payload(type, lhost, lport)
    payload_name = Rex::Text.rand_text_alpha(7)

    # Padd up 6 null bytes so the first few characters won't get cut off
    p = "\x00"*6
    Severity: Minor
    Found in modules/exploits/windows/fileformat/ms12_005.rb - About 1 hr to fix

      Method on_file_read has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def on_file_read(fname, file)
    f = open(file, 'rb')
    buf = f.read
    f.close
      Severity: Minor
      Found in modules/exploits/windows/fileformat/ms12_005.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def package_docm_rex(path)
    zip = Rex::Zip::Archive.new

    Dir["#{path}/**/**"].each do |file|
      p = file.sub(path+'/','')
        Severity: Major
        Found in modules/exploits/windows/fileformat/ms12_005.rb and 1 other location - About 1 hr to fix
        modules/exploits/multi/misc/openoffice_document_macro.rb on lines 188..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status