Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/fileformat/nitro_reader_jsapi.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method exploit has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    # In order to save binary data to the file system the payload is written to a .vbs
    # file and execute it from there.
    @payload_name = rand_text_alpha(4)
    @temp_folder  = "/Windows/Temp"
Severity: Major
Found in modules/exploits/windows/fileformat/nitro_reader_jsapi.rb - About 2 hrs to fix

    Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'           => 'Nitro Pro PDF Reader 11.0.3.173 Javascript API Remote Code Execution',
      'Description'    => %q{
          This module exploits an unsafe Javascript API implemented in Nitro and Nitro Pro
    Severity: Minor
    Found in modules/exploits/windows/fileformat/nitro_reader_jsapi.rb - About 1 hr to fix

      Method build_vbs has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def build_vbs(url, stager_name)
    name_xmlhttp  = rand_text_alpha(2)
    name_adodb    = rand_text_alpha(2)
    vbs           = %Q|<head><hta:application
    applicationname="#{@payload_name}"
      Severity: Minor
      Found in modules/exploits/windows/fileformat/nitro_reader_jsapi.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def on_request_uri(cli, request)
    if request.uri =~ /\.exe/
      print_status("Sending second stage payload")
      return if ((p=regenerate_payload(cli)) == nil)
      data = generate_payload_exe( {:code=>p.encoded} )
        Severity: Minor
        Found in modules/exploits/windows/fileformat/nitro_reader_jsapi.rb and 1 other location - About 25 mins to fix
        modules/exploits/windows/scada/scadapro_cmdexe.rb on lines 81..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status