rapid7/metasploit-framework

View on GitHub
modules/exploits/windows/ftp/turboftp_port.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method exploit has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    my_target = target
    if my_target.name == 'Automatic'
      print_status("Automatically detecting the target")
      connect
Severity: Major
Found in modules/exploits/windows/ftp/turboftp_port.rb - About 2 hrs to fix

    Method create_rop_chain has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create_rop_chain(ver)
        # rop chain generated with mona.py - www.corelan.be
        if ver == 823
          rop_gadgets =
          [
    Severity: Minor
    Found in modules/exploits/windows/ftp/turboftp_port.rb - About 1 hr to fix

      Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
          super(update_info(info,
            'Name'           => 'Turbo FTP Server 1.30.823 PORT Overflow',
            'Description'    => %q{
              This module exploits a buffer overflow vulnerability found in the PORT
      Severity: Minor
      Found in modules/exploits/windows/ftp/turboftp_port.rb - About 1 hr to fix

        Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
            my_target = target
            if my_target.name == 'Automatic'
              print_status("Automatically detecting the target")
              connect
        Severity: Minor
        Found in modules/exploits/windows/ftp/turboftp_port.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status