Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/ftp/wing_ftp_admin_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method check has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def check
    @session_cookie = authenticate(datastore['USERNAME'], datastore['PASSWORD'])
    if @session_cookie.nil?
      return CheckCode::Unknown
    end
Severity: Minor
Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check
    @session_cookie = authenticate(datastore['USERNAME'], datastore['PASSWORD'])
    if @session_cookie.nil?
      return CheckCode::Unknown
    end
Severity: Minor
Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 1 hr to fix

    Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Wing FTP Server Authenticated Command Execution',
      'Description'    => %q{
        This module exploits the embedded Lua interpreter in the admin web interface for
    Severity: Minor
    Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 1 hr to fix

      Method authenticate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def authenticate(username, password)
    res = send_request_cgi(
      'uri'       => '/admin_loginok.html',
      'method'    => 'POST',
      'vars_post' => {
      Severity: Minor
      Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 1 hr to fix

        Method authenticate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def authenticate(username, password)
    res = send_request_cgi(
      'uri'       => '/admin_loginok.html',
      'method'    => 'POST',
      'vars_post' => {
        Severity: Minor
        Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return CheckCode::Unknown
        Severity: Major
        Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return CheckCode::Vulnerable
          Severity: Major
          Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 30 mins to fix

            Method exploit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def exploit
    vprint_status("Authenticating...")
    unless [CheckCode::Vulnerable].include? check
      fail_with(Failure::NotVulnerable, 'Target is most likely not vulnerable!')
    end
            Severity: Minor
            Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method execute_command has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def execute_command(cmd,_opts = {})
    # Wrap cmd with [[ ]] to prevent potential problems.
    if @vuln_check == true
      command = "print(os.getenv([[#{cmd}]]))"
    else
            Severity: Minor
            Found in modules/exploits/windows/ftp/wing_ftp_admin_exec.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status