Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/bea_weblogic_post_bof.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Oracle Weblogic Apache Connector POST Request Buffer Overflow',
      'Description'    => %q{
          This module exploits a stack based buffer overflow in the BEA
Severity: Major
Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb - About 2 hrs to fix

    Method fingerprint_mod_wl has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def fingerprint_mod_wl

    my_data = rand_text_alpha(rand(5) + 8)
    res = send_request_cgi(
        {
    Severity: Minor
    Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb - About 1 hr to fix

      Method fingerprint_mod_wl has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def fingerprint_mod_wl

    my_data = rand_text_alpha(rand(5) + 8)
    res = send_request_cgi(
        {
      Severity: Minor
      Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

          if res and res.code == 200 and res.body =~ /Weblogic Bridge Message/
      # BEA WebLogic 8.1 SP6 - mod_wl_20.so
      case res.body
      when (/Build date\/time:<\/B> <I>Jun 16 2006 15:14:11/ and /Change Number:<\/B> <I>779586/)
        return "Version found: BEA WebLogic 8.1 SP6 - mod_wl_20.so"
      Severity: Major
      Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb - About 40 mins to fix

        Avoid too many return statements within this method.
        Open

              return nil
        Severity: Major
        Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return "BEA WebLogic connector undefined"
          Severity: Major
          Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return "BEA WebLogic connector not vulnerable"
            Severity: Major
            Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return "BEA WebLogic connector not found"
              Severity: Major
              Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          [  'BEA WebLogic 8.1 SP6 - mod_wl_20.so / Apache 2.0 / Windows [XP/2000]',
            {
              'Ret' => 0x10061f63, # push esp # ret # mod_wl_20.so
              'Offset' =>  4102
            }
                Severity: Minor
                Found in modules/exploits/windows/http/bea_weblogic_post_bof.rb and 1 other location - About 15 mins to fix
                modules/exploits/windows/http/syncbreeze_bof.rb on lines 49..68

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 25.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status