Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/forticlient_ems_fctid_sqli.rb

Summary

Maintainability
C
1 day
Test Coverage

Method get_register_info has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get_register_info
    if @version >= Rex::Version.new('7.2')
      vprint_status('Returning SYSINFO for 7.2 target')
      register_info = <<~REGISTER_INFO
        FCTOS=WIN64
Severity: Major
Found in modules/exploits/windows/http/forticlient_ems_fctid_sqli.rb - About 4 hrs to fix

    Method initialize has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'FortiNet FortiClient Endpoint Management Server FCTID SQLi to RCE',
    Severity: Major
    Found in modules/exploits/windows/http/forticlient_ems_fctid_sqli.rb - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            vprint_status('Returning SYSINFO for 7.0 target')
      register_info = <<~REGISTER_INFO
        AVSIG_VER=1.00000
        REG_KEY=_
        EP_ONNETCHKSUM=0
      Severity: Major
      Found in modules/exploits/windows/http/forticlient_ems_fctid_sqli.rb and 1 other location - About 1 hr to fix
      modules/exploits/windows/http/forticlient_ems_fctid_sqli.rb on lines 75..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            vprint_status('Returning SYSINFO for 7.2 target')
      register_info = <<~REGISTER_INFO
        FCTOS=WIN64
        OSVER=Microsoft Windows 10 Professional Edition, 64-bit (build 19045)
        RSENG_VER=1.00182
      Severity: Major
      Found in modules/exploits/windows/http/forticlient_ems_fctid_sqli.rb and 1 other location - About 1 hr to fix
      modules/exploits/windows/http/forticlient_ems_fctid_sqli.rb on lines 126..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status