rapid7/metasploit-framework

View on GitHub
modules/exploits/windows/http/gitstack_rce.rb

Summary

Maintainability
C
1 day
Test Coverage

File gitstack_rce.rb has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = GreatRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::Powershell
Severity: Minor
Found in modules/exploits/windows/http/gitstack_rce.rb - About 2 hrs to fix

    Method exploit has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
        command = cmd_psh_payload(
          payload.encoded,
          payload_instance.arch.first,
          { :remove_comspec => true, :encode_final_payload => true }
    Severity: Minor
    Found in modules/exploits/windows/http/gitstack_rce.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
        command = cmd_psh_payload(
          payload.encoded,
          payload_instance.arch.first,
          { :remove_comspec => true, :encode_final_payload => true }
    Severity: Minor
    Found in modules/exploits/windows/http/gitstack_rce.rb - About 1 hr to fix

      Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
          super(update_info(info,
            'Name'           => 'GitStack Unsanitized Argument RCE',
            'Description'    => %q{
              This module exploits a remote code execution vulnerability that
      Severity: Minor
      Found in modules/exploits/windows/http/gitstack_rce.rb - About 1 hr to fix

        Method check_repos has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check_repos
            begin
              res = send_request_cgi({
                'uri'     =>  '/rest/repository/',
                'method'  =>  'GET',
        Severity: Minor
        Found in modules/exploits/windows/http/gitstack_rce.rb - About 1 hr to fix

          Method check_repos has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def check_repos
              begin
                res = send_request_cgi({
                  'uri'     =>  '/rest/repository/',
                  'method'  =>  'GET',
          Severity: Minor
          Found in modules/exploits/windows/http/gitstack_rce.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method check_web has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def check_web
              begin
                res = send_request_cgi({
                  'uri'     =>  '/rest/settings/general/webinterface/',
                  'method'  => 'GET'
          Severity: Minor
          Found in modules/exploits/windows/http/gitstack_rce.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method repo_users has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def repo_users(repo)
              begin
                res = send_request_cgi({
                  'uri'     =>  "/rest/repository/#{repo}/user/",
                  'method'  =>  'GET'
          Severity: Minor
          Found in modules/exploits/windows/http/gitstack_rce.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def delete_repo(repo)
              begin
                res = send_request_cgi({
                  'uri'     =>  "/rest/repository/#{repo}/",
                  'method'  =>  'DELETE'
          Severity: Minor
          Found in modules/exploits/windows/http/gitstack_rce.rb and 1 other location - About 55 mins to fix
          modules/exploits/windows/http/gitstack_rce.rb on lines 181..194

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def delete_user(user)
              begin
                res = send_request_cgi({
                  'uri'     =>  "/rest/user/#{user}/",
                  'method'  =>  'DELETE'
          Severity: Minor
          Found in modules/exploits/windows/http/gitstack_rce.rb and 1 other location - About 55 mins to fix
          modules/exploits/windows/http/gitstack_rce.rb on lines 140..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              begin
                res = send_request_cgi({
                  'uri'     =>  '/rest/repository/',
                  'method'  =>  'GET',
                })
          Severity: Minor
          Found in modules/exploits/windows/http/gitstack_rce.rb and 1 other location - About 15 mins to fix
          modules/exploits/windows/http/gitstack_rce.rb on lines 46..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              begin
                res = send_request_cgi({
                  'uri'     =>  '/rest/settings/general/webinterface/',
                  'method'  => 'GET'
                })
          Severity: Minor
          Found in modules/exploits/windows/http/gitstack_rce.rb and 1 other location - About 15 mins to fix
          modules/exploits/windows/http/gitstack_rce.rb on lines 70..77

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status