Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/hp_nnm_ovbuildpath_textfile.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'HP OpenView Network Node Manager ov.dll _OVBuildPath Buffer Overflow',
Severity: Major
Found in modules/exploits/windows/http/hp_nnm_ovbuildpath_textfile.rb - About 2 hrs to fix

    Method exploit has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    print_status("Trying target #{target.name}...")

    install_path = get_install_path
    install_path << "help\\English_United States.1252"
    Severity: Major
    Found in modules/exploits/windows/http/hp_nnm_ovbuildpath_textfile.rb - About 2 hrs to fix

      Method get_install_path has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_install_path
    cgi = '/OvCgi/OpenView5.exe'
    web_session = rand_text_numeric(3)
    my_cookie = "OvOSLocale=English_United States.1252; "
    my_cookie << "OvAcceptLang=en-US; "
      Severity: Minor
      Found in modules/exploits/windows/http/hp_nnm_ovbuildpath_textfile.rb - About 1 hr to fix

        Method exploit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    print_status("Trying target #{target.name}...")

    install_path = get_install_path
    install_path << "help\\English_United States.1252"
        Severity: Minor
        Found in modules/exploits/windows/http/hp_nnm_ovbuildpath_textfile.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status