Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/hpe_sim_76_amf_deserialization.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method initialize has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'HPE Systems Insight Manager AMF Deserialization RCE',
Severity: Major
Found in modules/exploits/windows/http/hpe_sim_76_amf_deserialization.rb - About 2 hrs to fix

    Method payload_template_adjustments has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def payload_template_adjustments(original_content, cmd)
    original_content['PAYLOAD'] = cmd
    original_content[0x47A..0x47B] = [cmd.length].pack('n')
    second_adjustment_length = original_content[0x3C..].length * 2
    Severity: Minor
    Found in modules/exploits/windows/http/hpe_sim_76_amf_deserialization.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path)
    })
    Severity: Minor
    Found in modules/exploits/windows/http/hpe_sim_76_amf_deserialization.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path)
    })
      Severity: Minor
      Found in modules/exploits/windows/http/hpe_sim_76_amf_deserialization.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status