Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb

Summary

Maintainability
D
2 days
Test Coverage

File ivanti_avalanche_filestoreconfig_upload.rb has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::FileDropper
  prepend Msf::Exploit::Remote::AutoCheck
Severity: Minor
Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 3 hrs to fix

    Method upload_payload has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def upload_payload
    payload_name = "#{Rex::Text.rand_text_alpha(5..12)}.jsp"
    # need to 'select' webapps/AvalancheWeb to upload a file
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'app', 'FileStoreConfig.jsf'),
    Severity: Major
    Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 2 hrs to fix

      Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Ivanti Avalanche FileStoreConfig File Upload',
      Severity: Minor
      Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 1 hr to fix

        Method upload_payload has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          def upload_payload
    payload_name = "#{Rex::Text.rand_text_alpha(5..12)}.jsp"
    # need to 'select' webapps/AvalancheWeb to upload a file
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'app', 'FileStoreConfig.jsf'),
        Severity: Minor
        Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cleanup has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def cleanup
    if @cleanup_needed == false
      return
    end
        Severity: Minor
        Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 1 hr to fix

          Method configure_filestore has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def configure_filestore
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'app', 'FileStoreConfig.jsf'),
      'method' => 'GET',
      'keep_cookies' => true
          Severity: Minor
          Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 1 hr to fix

            Method check has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              def check
    # Cleanup should not be needed after doing just a check.
    @cleanup_needed = false

    res = send_request_cgi(
            Severity: Minor
            Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method authenticate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def authenticate
    if datastore['USERNAME'].blank? && datastore['PASSWORD'].blank?
      fail_with(Failure::BadConfig, 'Please set the USERNAME and PASSWORD options')
    end
            Severity: Minor
            Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 1 hr to fix

              Method configure_filestore has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def configure_filestore
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'app', 'FileStoreConfig.jsf'),
      'method' => 'GET',
      'keep_cookies' => true
              Severity: Minor
              Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method authenticate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def authenticate
    if datastore['USERNAME'].blank? && datastore['PASSWORD'].blank?
      fail_with(Failure::BadConfig, 'Please set the USERNAME and PASSWORD options')
    end
              Severity: Minor
              Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method cleanup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def cleanup
    if @cleanup_needed == false
      return
    end
              Severity: Minor
              Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_directory_val has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def get_directory_val(res, dir_name)
    html = res.get_html_document
    results = html.xpath('//tr[contains(@class, "DIRECTORY")]')
    fail_with(Failure::UnexpectedReply, 'Failed to find list of expected directories') unless results
              Severity: Minor
              Found in modules/exploits/windows/http/ivanti_avalanche_filestoreconfig_upload.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status