Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method exploit has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit

    peer = "#{rhost}:#{rport}"

    # Generate the ASP containing the EXE containing the payload
Severity: Major
Found in modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb - About 3 hrs to fix

    Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name'        => 'LANDesk Lenovo ThinkManagement Console Remote Command Execution',
      'Description'    => %q{
          This module can be used to execute a payload on LANDesk Lenovo
    Severity: Minor
    Found in modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit

    peer = "#{rhost}:#{rport}"

    # Generate the ASP containing the EXE containing the payload
      Severity: Minor
      Found in modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb - About 30 mins to fix

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            if (res.code < 200 or res.code >= 300)
      print_error("Execution failed on #{upload_path} [#{res.code} #{res.message}]")
      return
    end
        Severity: Minor
        Found in modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb and 5 other locations - About 15 mins to fix
        modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 106..109
        modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 165..168
        modules/exploits/windows/http/umbraco_upload_aspx.rb on lines 162..165
        modules/exploits/windows/iis/iis_webdav_upload_asp.rb on lines 109..112
        modules/exploits/windows/iis/iis_webdav_upload_asp.rb on lines 190..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            elsif (res.code < 200 or res.code >= 300)
      print_error("Upload failed on #{attack_url} [#{res.code} #{res.message}]")
      return
    end
        Severity: Minor
        Found in modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb and 5 other locations - About 15 mins to fix
        modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 127..130
        modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 165..168
        modules/exploits/windows/http/umbraco_upload_aspx.rb on lines 162..165
        modules/exploits/windows/iis/iis_webdav_upload_asp.rb on lines 109..112
        modules/exploits/windows/iis/iis_webdav_upload_asp.rb on lines 190..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            elsif (res.code < 200 or res.code >= 300)
      print_error("Deletion failed at #{attack_url} [#{res.code} #{res.message}]")
      return
    end
        Severity: Minor
        Found in modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb and 5 other locations - About 15 mins to fix
        modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 106..109
        modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 127..130
        modules/exploits/windows/http/umbraco_upload_aspx.rb on lines 162..165
        modules/exploits/windows/iis/iis_webdav_upload_asp.rb on lines 109..112
        modules/exploits/windows/iis/iis_webdav_upload_asp.rb on lines 190..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status