Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/manageengine_apps_mngr.rb

Summary

Maintainability
D
2 days
Test Coverage

Method exploit has 219 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    # Make initial request to get assigned a session token
    cookie = "pagerefresh=1; NfaupdateMsg=true; sortBy=sByName; testcookie=; "
    cookie << "am_username=;am_check="
    begin
Severity: Major
Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 1 day to fix

    Method exploit has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    # Make initial request to get assigned a session token
    cookie = "pagerefresh=1; NfaupdateMsg=true; sortBy=sByName; testcookie=; "
    cookie << "am_username=;am_check="
    begin
    Severity: Minor
    Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File manageengine_apps_mngr.rb has 256 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = AverageRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::EXE
    Severity: Minor
    Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 2 hrs to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return
        Severity: Major
        Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return
          Severity: Major
          Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return
            Severity: Major
            Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return
              Severity: Major
              Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return
                Severity: Major
                Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return
                  Severity: Major
                  Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return
                    Severity: Major
                    Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return
                      Severity: Major
                      Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return
                        Severity: Major
                        Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return
                          Severity: Major
                          Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                  return
                            Severity: Major
                            Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                    return
                              Severity: Major
                              Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                      return
                                Severity: Major
                                Found in modules/exploits/windows/http/manageengine_apps_mngr.rb - About 30 mins to fix

                                  Similar blocks of code found in 5 locations. Consider refactoring.
                                  Open

                                      register_options(
      [ Opt::RPORT(9090),
        OptString.new('URI', [false, "URI for Applications Manager", '/']),
        OptString.new('USER', [true, "username", 'admin']),
        OptString.new('PASS', [true, "password", 'admin']),
                                  Severity: Minor
                                  Found in modules/exploits/windows/http/manageengine_apps_mngr.rb and 4 other locations - About 15 mins to fix
                                  modules/exploits/multi/http/adobe_coldfusion_rce_cve_2023_26360.rb on lines 121..127
                                  modules/exploits/multi/misc/legend_bot_exec.rb on lines 56..62
                                  modules/exploits/multi/misc/w3tw0rk_exec.rb on lines 46..52
                                  modules/exploits/multi/misc/xdh_x_exec.rb on lines 58..64

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 26.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status