Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/sap_configservlet_exec_noauth.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'            => 'SAP ConfigServlet Remote Code Execution',
      'Description'     => %q{
        This module allows remote code execution via operating system commands through the
Severity: Minor
Found in modules/exploits/windows/http/sap_configservlet_exec_noauth.rb - About 1 hr to fix

    Method execute_command has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def execute_command(cmd, opts)
    commands = cmd.split(/&/)
    commands.each do |command|
      timeout = 20
      if datastore['DELETE_FILES'] and command =~ /shell\.run \"(.*)\"/
    Severity: Minor
    Found in modules/exploits/windows/http/sap_configservlet_exec_noauth.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status