Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/sharepoint_data_deserialization.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'SharePoint DataSet / DataTable Deserialization',
Severity: Major
Found in modules/exploits/windows/http/sharepoint_data_deserialization.rb - About 2 hrs to fix

    Method execute_command has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def execute_command(cmd, _opts = {})
    serialized = Rex::Text.encode_base64(::Msf::Util::DotNetDeserialization.generate(
      cmd,
      gadget_chain: :TextFormattingRunProperties,
      formatter: :LosFormatter
    Severity: Major
    Found in modules/exploits/windows/http/sharepoint_data_deserialization.rb - About 2 hrs to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

        def exploit
    case target['Type']
    when :windows_command
      execute_command(payload.encoded)
    when :windows_dropper
      Severity: Major
      Found in modules/exploits/windows/http/sharepoint_data_deserialization.rb and 2 other locations - About 55 mins to fix
      modules/exploits/windows/http/kentico_staging_syncserver.rb on lines 88..96
      modules/exploits/windows/http/sharepoint_workflows_xoml.rb on lines 91..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 17 locations. Consider refactoring.
      Open

          register_options([
      OptString.new('TARGETURI', [ true, 'The base path to the SharePoint application', '/' ]),
      OptString.new('DOMAIN', [ true, 'The domain to use for Windows authentication', 'WORKGROUP' ]),
      OptString.new('USERNAME', [ true, 'Username to authenticate as', '' ]),
      OptString.new('PASSWORD', [ true, 'The password to authenticate with', '' ])
      Severity: Major
      Found in modules/exploits/windows/http/sharepoint_data_deserialization.rb and 16 other locations - About 25 mins to fix
      modules/auxiliary/admin/http/joomla_registration_privesc.rb on lines 35..41
      modules/auxiliary/admin/http/kaseya_master_admin.rb on lines 36..42
      modules/auxiliary/admin/http/vbulletin_upgrade_admin.rb on lines 35..41
      modules/auxiliary/gather/mantisbt_admin_sqli.rb on lines 33..39
      modules/auxiliary/scanner/http/riverbed_steelhead_vcx_file_read.rb on lines 31..37
      modules/auxiliary/scanner/sap/sap_soap_rfc_pfl_check_os_file_existence.rb on lines 51..56
      modules/auxiliary/scanner/sap/sap_soap_rfc_rzl_read_dir.rb on lines 51..56
      modules/auxiliary/scanner/telephony/wardial.rb on lines 48..54
      modules/exploits/linux/http/froxlor_log_path_rce.rb on lines 67..73
      modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb on lines 48..53
      modules/exploits/unix/webapp/wp_google_document_embedder_exec.rb on lines 53..59
      modules/exploits/windows/http/ajaxpro_deserialization_rce.rb on lines 91..96
      modules/exploits/windows/http/apache_activemq_traversal_upload.rb on lines 61..66
      modules/exploits/windows/http/manageengine_adaudit_plus_authenticated_rce.rb on lines 89..94
      modules/exploits/windows/http/zentao_pro_rce.rb on lines 74..79
      modules/post/osx/manage/mount_share.rb on lines 51..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  'Windows EXE Dropper',
            {
              'Arch' => [ARCH_X86, ARCH_X64],
              'Type' => :windows_dropper
            }
      Severity: Minor
      Found in modules/exploits/windows/http/sharepoint_data_deserialization.rb and 2 other locations - About 20 mins to fix
      modules/exploits/windows/http/kentico_staging_syncserver.rb on lines 39..59
      modules/exploits/windows/http/sharepoint_workflows_xoml.rb on lines 34..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status