Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/trackercam_phparg_overflow.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'TrackerCam PHP Argument Buffer Overflow',
      'Description'    => %q{
          This module exploits a simple stack buffer overflow in the
Severity: Minor
Found in modules/exploits/windows/http/trackercam_phparg_overflow.rb - About 1 hr to fix

    Method fingerprint has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def fingerprint

    res = download_log(rand_text_alphanumeric(12) + '.txt')
    return if not res
    Severity: Minor
    Found in modules/exploits/windows/http/trackercam_phparg_overflow.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return "Windows XP SP0-SP1"
      Severity: Major
      Found in modules/exploits/windows/http/trackercam_phparg_overflow.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return "Unknown OS/SP"
        Severity: Major
        Found in modules/exploits/windows/http/trackercam_phparg_overflow.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return "Windows XP SP2+"
          Severity: Major
          Found in modules/exploits/windows/http/trackercam_phparg_overflow.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return "Windows 2003"
            Severity: Major
            Found in modules/exploits/windows/http/trackercam_phparg_overflow.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return "Windows 2000"
              Severity: Major
              Found in modules/exploits/windows/http/trackercam_phparg_overflow.rb - About 30 mins to fix

                Method fingerprint has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def fingerprint

    res = download_log(rand_text_alphanumeric(12) + '.txt')
    return if not res
                Severity: Minor
                Found in modules/exploits/windows/http/trackercam_phparg_overflow.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status