Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/http/vmware_vcenter_chargeback_upload.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'        => 'VMware vCenter Chargeback Manager ImageUploadServlet Arbitrary File Upload',
      'Description' => %q{
        This module exploits a code execution flaw in VMware vCenter Chargeback Manager,
Severity: Minor
Found in modules/exploits/windows/http/vmware_vcenter_chargeback_upload.rb - About 1 hr to fix

    Method on_new_session has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def on_new_session(cli)

    if not @dropper or @dropper.empty?
      return
    end
    Severity: Minor
    Found in modules/exploits/windows/http/vmware_vcenter_chargeback_upload.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

      def jsp_drop_bin(bin_data, output_file)
    jspraw =  %Q|<%@ page import="java.io.*" %>\n|
    jspraw << %Q|<%\n|
    jspraw << %Q|String data = "#{Rex::Text.to_hex(bin_data, "")}";\n|
    Severity: Major
    Found in modules/exploits/windows/http/vmware_vcenter_chargeback_upload.rb and 7 other locations - About 1 hr to fix
    modules/exploits/multi/http/sonicwall_gms_upload.rb on lines 234..258
    modules/exploits/windows/http/desktopcentral_file_upload.rb on lines 135..159
    modules/exploits/windows/http/desktopcentral_statusupdate_upload.rb on lines 125..149
    modules/exploits/windows/http/hp_autopass_license_traversal.rb on lines 211..235
    modules/exploits/windows/http/jira_collector_traversal.rb on lines 164..188
    modules/exploits/windows/http/manageengine_connectionid_write.rb on lines 55..79
    modules/exploits/windows/http/solarwinds_fsm_userlogin.rb on lines 108..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          files.each { |f|
        print_warning("Deleting: #{f['path'] + "\\" + f['name']}")
        cli.fs.file.rm(f['path'] + "\\" + f['name'])
    Severity: Minor
    Found in modules/exploits/windows/http/vmware_vcenter_chargeback_upload.rb and 1 other location - About 25 mins to fix
    modules/exploits/windows/http/umbraco_upload_aspx.rb on lines 81..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

      def jsp_execute_command(command)
    jspraw =  %Q|<%@ page import="java.io.*" %>\n|
    jspraw << %Q|<%\n|
    jspraw << %Q|try {\n|
    jspraw << %Q|  Runtime.getRuntime().exec("chmod +x #{command}");\n|
    Severity: Major
    Found in modules/exploits/windows/http/vmware_vcenter_chargeback_upload.rb and 5 other locations - About 25 mins to fix
    modules/exploits/linux/http/mutiny_frontend_upload.rb on lines 184..193
    modules/exploits/multi/http/sonicwall_gms_upload.rb on lines 261..270
    modules/exploits/windows/http/jira_collector_traversal.rb on lines 191..200
    modules/exploits/windows/http/manageengine_connectionid_write.rb on lines 82..91
    modules/exploits/windows/http/solarwinds_fsm_userlogin.rb on lines 137..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status