Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/iis/iis_webdav_upload_asp.rb

Summary

Maintainability
D
1 day
Test Coverage

Method exploit has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

  def exploit
    # Generate the ASP containing the EXE containing the payload
    exe  = generate_payload_exe
    asp  = Msf::Util::EXE.to_exe_asp(exe)
    path = datastore['PATH'].gsub('%RAND%', rand(0x10000000).to_s)
Severity: Minor
Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploit has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    # Generate the ASP containing the EXE containing the payload
    exe  = generate_payload_exe
    asp  = Msf::Util::EXE.to_exe_asp(exe)
    path = datastore['PATH'].gsub('%RAND%', rand(0x10000000).to_s)
Severity: Major
Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 4 hrs to fix

    Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name'        => 'Microsoft IIS WebDAV Write Access Code Execution',
      'Description' => %q{
          This module can be used to execute a payload on IIS servers that
    Severity: Minor
    Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return
        Severity: Major
        Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return
          Severity: Major
          Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return
            Severity: Major
            Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return
              Severity: Major
              Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return
                Severity: Major
                Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return
                  Severity: Major
                  Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb - About 30 mins to fix

                    Similar blocks of code found in 6 locations. Consider refactoring.
                    Open

                        if (res.code < 200 or res.code >= 300)
      # Changed this to a warning, because red is scary and if this part fails,
      # honestly it's not that bad. In most cases this is probably expected anyway
      # because by default we're using IWAM_*, which doesn't give us a lot of
      # freedom to begin with.
                    Severity: Minor
                    Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb and 5 other locations - About 15 mins to fix
                    modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 106..109
                    modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 127..130
                    modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 165..168
                    modules/exploits/windows/http/umbraco_upload_aspx.rb on lines 162..165
                    modules/exploits/windows/iis/iis_webdav_upload_asp.rb on lines 109..112

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 25.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 6 locations. Consider refactoring.
                    Open

                        if (res.code < 200 or res.code >= 300)
      print_error("Upload failed on #{path_tmp} [#{res.code} #{res.message}]")
      return
    end
                    Severity: Minor
                    Found in modules/exploits/windows/iis/iis_webdav_upload_asp.rb and 5 other locations - About 15 mins to fix
                    modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 106..109
                    modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 127..130
                    modules/exploits/windows/http/landesk_thinkmanagement_upload_asp.rb on lines 165..168
                    modules/exploits/windows/http/umbraco_upload_aspx.rb on lines 162..165
                    modules/exploits/windows/iis/iis_webdav_upload_asp.rb on lines 190..197

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 25.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status