Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/iis/ms01_026_dbldecode.rb

Summary

Maintainability
C
1 day
Test Coverage

Method exploit has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def exploit
    @win_dir = datastore['WINDIR'] || detect_windows_directory

    fail_with(Failure::NotVulnerable, 'Unable to detect the target host Windows directory (maybe not vulnerable)!') unless @win_dir
Severity: Minor
Found in modules/exploits/windows/iis/ms01_026_dbldecode.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'MS01-026 Microsoft IIS/PWS CGI Filename Double Decode Command Execution',
Severity: Major
Found in modules/exploits/windows/iis/ms01_026_dbldecode.rb - About 2 hrs to fix

    Method detect_windows_directory has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def detect_windows_directory
    win_dirs = %w[winnt windows]
    matches = [
      'Directory of',
      '\\inetpub\\',
    Severity: Minor
    Found in modules/exploits/windows/iis/ms01_026_dbldecode.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    @win_dir = datastore['WINDIR'] || detect_windows_directory

    fail_with(Failure::NotVulnerable, 'Unable to detect the target host Windows directory (maybe not vulnerable)!') unless @win_dir
    Severity: Minor
    Found in modules/exploits/windows/iis/ms01_026_dbldecode.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status