Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/local/always_install_elevated.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info, {
      'Name'          => 'Windows AlwaysInstallElevated MSI',
      'Description'    => %q{
          This module checks the AlwaysInstallElevated registry keys which dictates if
Severity: Minor
Found in modules/exploits/windows/local/always_install_elevated.rb - About 1 hr to fix

    Method exploit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit

    return unless check == Msf::Exploit::CheckCode::Vulnerable

    msi_filename = Rex::Text.rand_text_alpha((rand(8)+6)) + ".msi"
    Severity: Minor
    Found in modules/exploits/windows/local/always_install_elevated.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit

    return unless check == Msf::Exploit::CheckCode::Vulnerable

    msi_filename = Rex::Text.rand_text_alpha((rand(8)+6)) + ".msi"
      Severity: Minor
      Found in modules/exploits/windows/local/always_install_elevated.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return Msf::Exploit::CheckCode::Vulnerable
      Severity: Major
      Found in modules/exploits/windows/local/always_install_elevated.rb - About 30 mins to fix

        Method check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    install_elevated = "AlwaysInstallElevated"
    installer = "SOFTWARE\\Policies\\Microsoft\\Windows\\Installer"
    hkcu = "HKEY_CURRENT_USER\\#{installer}"
    hklm = "HKEY_LOCAL_MACHINE\\#{installer}"
        Severity: Minor
        Found in modules/exploits/windows/local/always_install_elevated.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status