Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/local/bits_ntlm_token_impersonation.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        {
Severity: Major
Found in modules/exploits/windows/local/bits_ntlm_token_impersonation.rb - About 4 hrs to fix

    Method check has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    privs = client.sys.config.getprivs
    version = get_version_info
    # Fast fails
    if version.build_number < Msf::WindowsVersion::Win8 && !version.windows_server?
    Severity: Minor
    Found in modules/exploits/windows/local/bits_ntlm_token_impersonation.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    payload_name = datastore['PAYLOAD']
    payload_arch = framework.payloads.create(payload_name).arch
    winrm_port = datastore['WINRM_RPORT']
    host_process_name = datastore['HOST_PROCESS']
    Severity: Minor
    Found in modules/exploits/windows/local/bits_ntlm_token_impersonation.rb - About 1 hr to fix

      Method check has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    privs = client.sys.config.getprivs
    version = get_version_info
    # Fast fails
    if version.build_number < Msf::WindowsVersion::Win8 && !version.windows_server?
      Severity: Minor
      Found in modules/exploits/windows/local/bits_ntlm_token_impersonation.rb - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

              return BITS + WINRM
        Severity: Major
        Found in modules/exploits/windows/local/bits_ntlm_token_impersonation.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return Exploit::CheckCode::Safe
          Severity: Major
          Found in modules/exploits/windows/local/bits_ntlm_token_impersonation.rb - About 30 mins to fix

            Method check_bits_and_winrm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def check_bits_and_winrm
    result = cmd_exec('cmd.exe', '/c echo . | powershell.exe Get-Service -Name BITS,WinRM')
    vprint_status('Checking if BITS and WinRM are stopped...')

    if result.include?('~~')
            Severity: Minor
            Found in modules/exploits/windows/local/bits_ntlm_token_impersonation.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                begin
      process = client.sys.process.open(notepad_process.pid, PROCESS_ALL_ACCESS)
      print_good("Process #{process.pid} launched.")
    rescue Rex::Post::Meterpreter::RequestError
      # Reader Sandbox won't allow to create a new process:
            Severity: Minor
            Found in modules/exploits/windows/local/bits_ntlm_token_impersonation.rb and 2 other locations - About 25 mins to fix
            lib/msf/core/post/windows/process.rb on lines 89..96
            modules/exploits/windows/local/ms16_075_reflection_juicy.rb on lines 162..167

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status