Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/local/bypassuac_sluihijack.rb

Summary

Maintainability
C
1 day
Test Coverage

Method exploit has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def exploit
    # Validate that we can actually do things before we bother
    # doing any more work
    check_permissions!
Severity: Minor
Found in modules/exploits/windows/local/bypassuac_sluihijack.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploit has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    # Validate that we can actually do things before we bother
    # doing any more work
    check_permissions!
Severity: Major
Found in modules/exploits/windows/local/bypassuac_sluihijack.rb - About 2 hrs to fix

    Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows UAC Protection Bypass (Via Slui File Handler Hijack)',
    Severity: Minor
    Found in modules/exploits/windows/local/bypassuac_sluihijack.rb - About 1 hr to fix

      Method check_permissions! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_permissions!
    unless check == Exploit::CheckCode::Appears
      fail_with(Failure::NotVulnerable, 'Target is not vulnerable.')
    end
    fail_with(Failure::None, 'Already in elevated state') if is_admin? || is_system?
      Severity: Minor
      Found in modules/exploits/windows/local/bypassuac_sluihijack.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

        def check_permissions!
    unless check == Exploit::CheckCode::Appears
      fail_with(Failure::NotVulnerable, 'Target is not vulnerable.')
    end
    fail_with(Failure::None, 'Already in elevated state') if is_admin? || is_system?
      Severity: Major
      Found in modules/exploits/windows/local/bypassuac_sluihijack.rb and 3 other locations - About 1 hr to fix
      modules/exploits/windows/local/bypassuac_dotnet_profiler.rb on lines 199..219
      modules/exploits/windows/local/bypassuac_windows_store_filesys.rb on lines 125..145
      modules/exploits/windows/local/bypassuac_windows_store_reg.rb on lines 142..162

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if sysinfo['Architecture'] == ARCH_X64
      if session.arch == ARCH_X86
        # On x64, check arch
        commspec = '%WINDIR%\\Sysnative\\cmd.exe /c powershell'
        if target_arch.first == ARCH_X64
      Severity: Minor
      Found in modules/exploits/windows/local/bypassuac_sluihijack.rb and 1 other location - About 40 mins to fix
      modules/exploits/windows/local/bypassuac_fodhelper.rb on lines 84..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          case get_uac_level
    when UAC_PROMPT_CREDS_IF_SECURE_DESKTOP,
      UAC_PROMPT_CONSENT_IF_SECURE_DESKTOP,
      UAC_PROMPT_CREDS, UAC_PROMPT_CONSENT
      fail_with(Failure::NotVulnerable,
      Severity: Major
      Found in modules/exploits/windows/local/bypassuac_sluihijack.rb and 11 other locations - About 15 mins to fix
      modules/exploits/windows/local/bypassuac.rb on lines 81..92
      modules/exploits/windows/local/bypassuac_comhijack.rb on lines 98..111
      modules/exploits/windows/local/bypassuac_dotnet_profiler.rb on lines 112..125
      modules/exploits/windows/local/bypassuac_eventvwr.rb on lines 104..117
      modules/exploits/windows/local/bypassuac_fodhelper.rb on lines 111..124
      modules/exploits/windows/local/bypassuac_injection.rb on lines 78..91
      modules/exploits/windows/local/bypassuac_sdclt.rb on lines 86..99
      modules/exploits/windows/local/bypassuac_vbs.rb on lines 55..68
      modules/exploits/windows/local/bypassuac_windows_store_filesys.rb on lines 82..95
      modules/exploits/windows/local/bypassuac_windows_store_reg.rb on lines 75..88
      modules/exploits/windows/local/docker_credential_wincred.rb on lines 71..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status