Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/local/cve_2017_8464_lnk_lpe.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'LNK Code Execution Vulnerability',
Severity: Major
Found in modules/exploits/windows/local/cve_2017_8464_lnk_lpe.rb - About 2 hrs to fix

    Method generate_link has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def generate_link(path)
    vprint_status("Generating LNK file to load: #{path}")
    path += "\x00" # Do not use << here
    display_name = datastore['LnkDisplayName'].dup << "\x00" # LNK Display Name
    comment = datastore['LnkComment'].dup << "\x00"
    Severity: Minor
    Found in modules/exploits/windows/local/cve_2017_8464_lnk_lpe.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    if is_system?
      fail_with(Failure::None, 'Session is already elevated')
    end
      Severity: Minor
      Found in modules/exploits/windows/local/cve_2017_8464_lnk_lpe.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exploit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def exploit
    if is_system?
      fail_with(Failure::None, 'Session is already elevated')
    end
      Severity: Minor
      Found in modules/exploits/windows/local/cve_2017_8464_lnk_lpe.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status