Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/local/cve_2021_40449.rb

Summary

Maintainability
D
2 days
Test Coverage

Method check has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  def check
    if session.platform != 'windows'
      # Non-Windows systems are definitely not affected.
      return CheckCode::Safe('Target is not a Windows system, so it is not affected by this vulnerability!')
    end
Severity: Minor
Found in modules/exploits/windows/local/cve_2021_40449.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        {
Severity: Major
Found in modules/exploits/windows/local/cve_2021_40449.rb - About 2 hrs to fix

    Method check has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    if session.platform != 'windows'
      # Non-Windows systems are definitely not affected.
      return CheckCode::Safe('Target is not a Windows system, so it is not affected by this vulnerability!')
    end
    Severity: Minor
    Found in modules/exploits/windows/local/cve_2021_40449.rb - About 2 hrs to fix

      Avoid too many return statements within this method.
      Open

            return CheckCode::Appears('Vulnerable Windows 10 20H1 build detected!')
      Severity: Major
      Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return CheckCode::Appears('Vulnerable Windows 10 v1909 build detected!')
        Severity: Major
        Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return CheckCode::Appears('Vulnerable Windows 10 v1903 build detected!')
          Severity: Major
          Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Detected('Windows 8/Windows Server 2012 build detected!')
            Severity: Major
            Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return CheckCode::Appears('Vulnerable Windows 10 v1809 build detected!')
              Severity: Major
              Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return CheckCode::Appears('Vulnerable Windows 10 v1803 build detected!')
                Severity: Major
                Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return CheckCode::Appears('Vulnerable Windows 10 v1703 build detected!')
                  Severity: Major
                  Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return CheckCode::Appears('Vulnerable Windows 10 v1709 build detected!')
                    Severity: Major
                    Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return CheckCode::Appears('Vulnerable Windows 10 v1507 build detected!')
                      Severity: Major
                      Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return CheckCode::Appears('Vulnerable Windows 10 v1607 build detected!')
                        Severity: Major
                        Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return CheckCode::Appears('Vulnerable Windows 10 v1511 build detected!')
                          Severity: Major
                          Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                  return CheckCode::Appears('Vulnerable Windows 10 21H1 build detected!')
                            Severity: Major
                            Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                    return CheckCode::Appears('Vulnerable Windows 10 20H2 build detected!')
                              Severity: Major
                              Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                      return CheckCode::Appears('Vulnerable Windows 10 21H2 build detected!')
                                Severity: Major
                                Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                        return CheckCode::Detected('Windows 8.1/Windows Server 2012 R2 build detected!')
                                  Severity: Major
                                  Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                          return CheckCode::Detected('Windows 7/Windows Server 2008 R2 build detected!')
                                    Severity: Major
                                    Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                            return CheckCode::Safe('The build number of the target machine does not appear to be a vulnerable version!')
                                      Severity: Major
                                      Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                              return CheckCode::Detected('Windows Server 2008/Windows Server 2008 SP2 build detected!')
                                        Severity: Major
                                        Found in modules/exploits/windows/local/cve_2021_40449.rb - About 30 mins to fix

                                          Similar blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                            def exploit
    if is_system?
      fail_with(Failure::None, 'Session is already elevated')
    end
                                          Severity: Major
                                          Found in modules/exploits/windows/local/cve_2021_40449.rb and 2 other locations - About 1 hr to fix
                                          modules/exploits/windows/local/cve_2022_21882_win32k.rb on lines 109..128
                                          modules/exploits/windows/local/cve_2023_28252_clfs_driver.rb on lines 105..124

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 76.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                              unless version.build_number.between?(Msf::WindowsVersion::Server2008_SP0, Msf::WindowsVersion::Win10_21H1) ||
           version.build_number == Msf::WindowsVersion::Server2022 ||
           version.build_number == Msf::WindowsVersion::Win11_21H2
      return CheckCode::Safe('Target is not running a vulnerable version of Windows!')
    end
                                          Severity: Minor
                                          Found in modules/exploits/windows/local/cve_2021_40449.rb and 1 other location - About 20 mins to fix
                                          modules/exploits/windows/local/cve_2022_26904_superprofile.rb on lines 96..100

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 28.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          There are no issues that match your filters.

                                          Category
                                          Status