Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/local/docker_credential_wincred.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Docker-Credential-Wincred.exe Privilege Escalation',
Severity: Minor
Found in modules/exploits/windows/local/docker_credential_wincred.rb - About 1 hr to fix

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        case get_uac_level
    when UAC_PROMPT_CREDS_IF_SECURE_DESKTOP,
      UAC_PROMPT_CONSENT_IF_SECURE_DESKTOP,
      UAC_PROMPT_CREDS, UAC_PROMPT_CONSENT
      fail_with(Failure::NotVulnerable,
    Severity: Major
    Found in modules/exploits/windows/local/docker_credential_wincred.rb and 11 other locations - About 15 mins to fix
    modules/exploits/windows/local/bypassuac.rb on lines 81..92
    modules/exploits/windows/local/bypassuac_comhijack.rb on lines 98..111
    modules/exploits/windows/local/bypassuac_dotnet_profiler.rb on lines 112..125
    modules/exploits/windows/local/bypassuac_eventvwr.rb on lines 104..117
    modules/exploits/windows/local/bypassuac_fodhelper.rb on lines 111..124
    modules/exploits/windows/local/bypassuac_injection.rb on lines 78..91
    modules/exploits/windows/local/bypassuac_sdclt.rb on lines 86..99
    modules/exploits/windows/local/bypassuac_sluihijack.rb on lines 112..125
    modules/exploits/windows/local/bypassuac_vbs.rb on lines 55..68
    modules/exploits/windows/local/bypassuac_windows_store_filesys.rb on lines 82..95
    modules/exploits/windows/local/bypassuac_windows_store_reg.rb on lines 75..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status