Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/local/ms_ndproxy.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def disclose_addresses(t)
    addresses = {}

    hal_dispatch_table = find_haldispatchtable
    return nil if hal_dispatch_table.nil?
Severity: Major
Found in modules/exploits/windows/local/ms_ndproxy.rb and 1 other location - About 1 hr to fix
modules/exploits/windows/local/bthpan.rb on lines 108..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

            %w[CVE 2013-5065],
            %w[MSB MS14-002],
            %w[OSVDB 100368],
            %w[BID 63971],
            %w[EDB 30014],
Severity: Major
Found in modules/exploits/windows/local/ms_ndproxy.rb and 16 other locations - About 25 mins to fix
modules/auxiliary/scanner/smb/smb_ms17_010.rb on lines 37..46
modules/exploits/freebsd/local/intel_sysret_priv_esc.rb on lines 52..61
modules/exploits/linux/local/af_packet_chocobo_root_priv_esc.rb on lines 59..68
modules/exploits/linux/local/docker_cgroup_escape.rb on lines 49..58
modules/exploits/linux/local/network_manager_vpnc_username_priv_esc.rb on lines 45..54
modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb on lines 60..69
modules/exploits/linux/local/ufo_privilege_escalation.rb on lines 57..66
modules/exploits/multi/fileformat/evince_cbt_cmd_injection.rb on lines 42..51
modules/exploits/multi/http/joomla_http_header_rce.rb on lines 31..40
modules/exploits/multi/script/web_delivery.rb on lines 79..88
modules/exploits/solaris/local/libnspr_nspr_log_file_priv_esc.rb on lines 39..48
modules/exploits/solaris/local/rsh_stack_clash_priv_esc.rb on lines 45..54
modules/exploits/unix/smtp/exim4_string_format.rb on lines 49..58
modules/exploits/unix/webapp/open_flash_chart_upload_exec.rb on lines 30..39
modules/exploits/windows/http/exchange_proxylogon_rce.rb on lines 46..58
modules/exploits/windows/scada/rockwell_factorytalk_rce.rb on lines 32..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status