Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/local/s4u_persistence.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Manage User Level Persistent Payload Installer',
Severity: Major
Found in modules/exploits/windows/local/s4u_persistence.rb - About 2 hrs to fix

    File s4u_persistence.rb has 254 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Local
  Rank = ExcellentRanking

  include Msf::Post::File
  include Msf::Post::Windows::Priv
    Severity: Minor
    Found in modules/exploits/windows/local/s4u_persistence.rb - About 2 hrs to fix

      Method create_task has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create_task(path, schname, rexe_path)
    # create task using XML file on victim fs
    create_task_response = cmd_exec('cmd.exe', "/c schtasks /create /xml #{path} /tn \"#{schname}\"")
    if create_task_response =~ /has successfully been created/
      print_good("Persistence task #{schname} created successfully")
      Severity: Minor
      Found in modules/exploits/windows/local/s4u_persistence.rb - About 1 hr to fix

        Method add_xml_triggers has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def add_xml_triggers(xml)
    # Insert trigger
    case datastore['TRIGGER']
    when 'logon'
      # Trigger based on winlogon event, checks windows license key after logon
        Severity: Minor
        Found in modules/exploits/windows/local/s4u_persistence.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method add_xml_triggers has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def add_xml_triggers(xml)
    # Insert trigger
    case datastore['TRIGGER']
    when 'logon'
      # Trigger based on winlogon event, checks windows license key after logon
        Severity: Minor
        Found in modules/exploits/windows/local/s4u_persistence.rb - About 1 hr to fix

          Method create_task has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def create_task(path, schname, rexe_path)
    # create task using XML file on victim fs
    create_task_response = cmd_exec('cmd.exe', "/c schtasks /create /xml #{path} /tn \"#{schname}\"")
    if create_task_response =~ /has successfully been created/
      print_good("Persistence task #{schname} created successfully")
          Severity: Minor
          Found in modules/exploits/windows/local/s4u_persistence.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method exploit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def exploit
    version = get_version_info
    unless version.build_number >= Msf::WindowsVersion::Vista_SP0
      fail_with(Failure::NoTarget, 'This module only works on Vista/2008 and above')
    end
          Severity: Minor
          Found in modules/exploits/windows/local/s4u_persistence.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              begin
      vt = client.railgun.kernel32.GetLocalTime(32)
      ut = vt['lpSystemTime'].unpack('v*')
      t = ::Time.utc(ut[0], ut[1], ut[3], ut[4], ut[5])
    rescue StandardError
          Severity: Minor
          Found in modules/exploits/windows/local/s4u_persistence.rb and 1 other location - About 45 mins to fix
          modules/exploits/windows/local/s4u_persistence.rb on lines 242..248

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              begin
      vt = client.railgun.kernel32.GetLocalTime(32)
      ut = vt['lpSystemTime'].unpack('v*')
      t = ::Time.utc(ut[0], ut[1], ut[3], ut[4], ut[5])
    rescue StandardError
          Severity: Minor
          Found in modules/exploits/windows/local/s4u_persistence.rb and 1 other location - About 45 mins to fix
          modules/exploits/windows/local/s4u_persistence.rb on lines 161..167

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                report_note(host: session.session_host,
                  type: 'host.s4u_persistance.cleanup',
                  data: {
                    session_num: session.sid,
                    stype: session.type,
          Severity: Minor
          Found in modules/exploits/windows/local/s4u_persistence.rb and 1 other location - About 30 mins to fix
          modules/post/windows/gather/word_unc_injector.rb on lines 202..215

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status