Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/misc/ibm_director_cim_dllinject.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method process_propfind has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def process_propfind(cli, request, target)
    path = request.uri
    print_status("Received WebDAV PROPFIND request")
    body = ''
Severity: Minor
Found in modules/exploits/windows/misc/ibm_director_cim_dllinject.rb - About 1 hr to fix

    Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name'          => 'IBM System Director Agent DLL Injection',
      'Description'   => %q{
          This module abuses the "wmicimsv" service on IBM System Director Agent 5.20.3
    Severity: Minor
    Found in modules/exploits/windows/misc/ibm_director_cim_dllinject.rb - About 1 hr to fix

      Method on_request_uri has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)

    mytarget = target
    if target.name == 'Automatic'
      mytarget = auto_target(cli, request)
      Severity: Minor
      Found in modules/exploits/windows/misc/ibm_director_cim_dllinject.rb - About 1 hr to fix

        Method xml_data has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def xml_data
    xml = <<-eos
<?xml version="1.0" encoding="utf-8" ?>
<CIM CIMVERSION="2.0" DTDVERSION="2.0">
  <MESSAGE ID="1007" PROTOCOLVERSION="1.0">
        Severity: Minor
        Found in modules/exploits/windows/misc/ibm_director_cim_dllinject.rb - About 1 hr to fix

          Method on_request_uri has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def on_request_uri(cli, request)

    mytarget = target
    if target.name == 'Automatic'
      mytarget = auto_target(cli, request)
          Severity: Minor
          Found in modules/exploits/windows/misc/ibm_director_cim_dllinject.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            def auto_target(cli, request)
    agent = request.headers['User-Agent']

    ret = nil
    # Check for MSIE and/or WebDAV redirector requests
          Severity: Minor
          Found in modules/exploits/windows/misc/ibm_director_cim_dllinject.rb and 2 other locations - About 25 mins to fix
          modules/exploits/windows/browser/java_ws_arginject_altjvm.rb on lines 76..90
          modules/exploits/windows/browser/java_ws_vmargs.rb on lines 73..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 30.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status