Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb

Summary

Maintainability
F
3 days
Test Coverage

Method process_propfind has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def process_propfind(cli, request)
    path = request.uri
    print_status("PROPFIND #{path}")
    body = ''
Severity: Major
Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 4 hrs to fix

    File vmhgfs_webdav_dll_sideload.rb has 299 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = NormalRanking

  include Msf::Exploit::Remote::HttpServer::HTML
  include Msf::Exploit::EXE
    Severity: Minor
    Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 3 hrs to fix

      Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(info,
      'Name'           => 'DLL Side Loading Vulnerability in VMware Host Guest Client Redirector',
      'Description'    => %q{
      A DLL side loading vulnerability was found in the VMware Host Guest Client Redirector,
      Severity: Minor
      Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 1 hr to fix

        Method process_propfind has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def process_propfind(cli, request)
    path = request.uri
    print_status("PROPFIND #{path}")
    body = ''
        Severity: Minor
        Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generate_files has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def generate_files(path)
    trail = path.split("/")
    return "" if trail.length < 2

    %Q|
        Severity: Minor
        Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 1 hr to fix

          Method generate_shares has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def generate_shares(path)
    share_name = datastore['SHARENAME']
%Q|
<D:response xmlns:lp1="DAV:" xmlns:lp2="http://apache.org/dav/props/">
<D:href>#{path}#{share_name}/</D:href>
          Severity: Minor
          Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 1 hr to fix

            Method process_get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def process_get(cli, request)
    myhost = (datastore['SRVHOST'] == '0.0.0.0') ? Rex::Socket.source_address(cli.peerhost) : datastore['SRVHOST']
    webdav = "\\\\#{myhost}\\"

    if (request.uri =~ /vmhgfs\.dll$/i)
            Severity: Minor
            Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 1 hr to fix

              Method process_get has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def process_get(cli, request)
    myhost = (datastore['SRVHOST'] == '0.0.0.0') ? Rex::Socket.source_address(cli.peerhost) : datastore['SRVHOST']
    webdav = "\\\\#{myhost}\\"

    if (request.uri =~ /vmhgfs\.dll$/i)
              Severity: Minor
              Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                  return true if uri =~ /\.tmp$/i
              Severity: Major
              Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return true if uri =~ /(pcap|packet)\.dll/i
                Severity: Major
                Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 30 mins to fix

                  Method blacklisted_path? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def blacklisted_path?(uri)
    return true if uri =~ /\.exe/i
    return true if uri =~ /\.(config|manifest)/i
    return true if uri =~ /desktop\.ini/i
    return true if uri =~ /lib.*\.dll/i
                  Severity: Minor
                  Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    def process_propfind(cli, request)
    path = request.uri
    print_status("PROPFIND #{path}")
    body = ''
                  Severity: Major
                  Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb and 2 other locations - About 6 hrs to fix
                  modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 191..307
                  modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 145..261

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 204.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 7 locations. Consider refactoring.
                  Open

                    def on_request_uri(cli, request)
    case request.method
    when 'OPTIONS'
      process_options(cli, request)
    when 'PROPFIND'
                  Severity: Major
                  Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb and 6 other locations - About 1 hr to fix
                  modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 64..78
                  modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 67..80
                  modules/exploits/windows/http/cogent_datahub_command.rb on lines 64..77
                  modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 61..74
                  modules/exploits/windows/misc/wireshark_lua.rb on lines 62..75
                  modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 58..71

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 48.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 10 locations. Consider refactoring.
                  Open

                    def process_options(cli, request)
    print_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
                  Severity: Major
                  Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb and 9 other locations - About 50 mins to fix
                  modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
                  modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
                  modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
                  modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
                  modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
                  modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
                  modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
                  modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
                  modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 43.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def blacklisted_path?(uri)
    return true if uri =~ /\.exe/i
    return true if uri =~ /\.(config|manifest)/i
    return true if uri =~ /desktop\.ini/i
    return true if uri =~ /lib.*\.dll/i
                  Severity: Minor
                  Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb and 1 other location - About 45 mins to fix
                  modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 344..351

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 39.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      register_options(
      [
        OptPort.new('SRVPORT',     [ true, "The daemon port to listen on (do not change)", 80 ]),
        OptString.new('URIPATH',   [ true, "The URI to use (do not change)", "/" ]),
        OptString.new('BASENAME',  [ true, "The base name for the docx file", "Document1" ]),
                  Severity: Minor
                  Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb and 3 other locations - About 25 mins to fix
                  modules/auxiliary/admin/http/sysaid_admin_acct.rb on lines 34..40
                  modules/auxiliary/scanner/http/smt_ipmi_url_redirect_traversal.rb on lines 42..48
                  modules/exploits/windows/misc/wireshark_lua.rb on lines 51..57

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 30.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status