Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/mssql/mssql_linkcrawler.rb

Summary

Maintainability
F
5 days
Test Coverage

Method exploit has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
Open

  def exploit
    # Display start time
    time1 = Time.new
    print_status("-------------------------------------------------")
    print_status("Start time : #{time1.inspect}")
Severity: Minor
Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enable_xp_cmdshell has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

  def enable_xp_cmdshell(path,name,shelled)
    # Enables "show advanced options" and xp_cmdshell if needed and possible
    # They cannot be enabled in user transactions (i.e. via openquery)
    # Only enabled if RPC_Out is enabled for linked server
    # All changes are reverted after payload delivery and execution
Severity: Minor
Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploit has 142 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    # Display start time
    time1 = Time.new
    print_status("-------------------------------------------------")
    print_status("Start time : #{time1.inspect}")
Severity: Major
Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 5 hrs to fix

    File mssql_linkcrawler.rb has 390 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = GreatRanking

  include Msf::Exploit::Remote::MSSQL
  include Msf::Auxiliary::Report
    Severity: Minor
    Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 5 hrs to fix

      Method enable_xp_cmdshell has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def enable_xp_cmdshell(path,name,shelled)
    # Enables "show advanced options" and xp_cmdshell if needed and possible
    # They cannot be enabled in user transactions (i.e. via openquery)
    # Only enabled if RPC_Out is enabled for linked server
    # All changes are reverted after payload delivery and execution
      Severity: Major
      Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 2 hrs to fix

        Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Microsoft SQL Server Database Link Crawling Command Execution',
      'Description'    => %q{
          This module can be used to crawl MS SQL Server database links and deploy
        Severity: Minor
        Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 2 hrs to fix

          Method powershell_upload_exec has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def powershell_upload_exec(path)

    # Create powershell script that will inject shell code from the selected payload
    myscript ="$code = @\"
[DllImport(\"kernel32.dll\")]
          Severity: Minor
          Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                              if masterList[x]["name"] == name
                    masterList[x]["path"] << server["path"].first.dup
                    masterList[x]["path"].last << name
                    unless shelled.include?(name)
                      if parse_results[0][2]==1
            Severity: Major
            Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 45 mins to fix

              Method write_to_report has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def write_to_report(i,server,parse_results,linked_server_table,link_status)
              Severity: Minor
              Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 35 mins to fix

                Method show_configs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def show_configs(i,parse_results,entry=false)

    print_status(" ")
    parse_results.each {|stuff|
                Severity: Minor
                Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        print_status("Linked Server: #{i}")
        print_status("  o Link user: #{stuff.at(1)}")
        print_status("  o Link privs: #{dbpriv}")
        print_status("  o Link version: #{stuff.at(3)}")
        print_status("  o Link OS: #{stuff.at(4).strip}")
                Severity: Minor
                Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb and 1 other location - About 35 mins to fix
                modules/exploits/windows/mssql/mssql_linkcrawler.rb on lines 353..358

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        print_status("Server: #{i}")
        print_status("  o Server user: #{stuff.at(1)}")
        print_status("  o Server privs: #{dbpriv}")
        print_status("  o Server version: #{stuff.at(3)}")
        print_status("  o Server OS: #{stuff.at(4).strip}")
                Severity: Minor
                Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb and 1 other location - About 35 mins to fix
                modules/exploits/windows/mssql/mssql_linkcrawler.rb on lines 346..351

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (save_loot=="yes")
      filename= "#{mssql_client.peerhost}-#{mssql_client.peerport}_linked_servers.csv"
      path = store_loot("crawled_links", "text/plain", mssql_client.peerhost, linked_server_table.to_csv, filename, "Linked servers",this_service)
      print_good("Results have been saved to: #{path}")
                Severity: Minor
                Found in modules/exploits/windows/mssql/mssql_linkcrawler.rb and 1 other location - About 25 mins to fix
                modules/auxiliary/admin/mssql/mssql_findandsampledata.rb on lines 454..457

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 30.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status