Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize
    super(
      'Name'          => 'GE Proficy CIMPLICITY gefebt.exe Remote Code Execution',
      'Description'   => %q{
        This module abuses the gefebt.exe component in GE Proficy CIMPLICITY, reachable through the
Severity: Minor
Found in modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb - About 1 hr to fix

    Method process_propfind has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def process_propfind(cli, request)
    path = request.uri
    print_status("Received WebDAV PROPFIND request")
    body = ''
    Severity: Minor
    Found in modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb - About 1 hr to fix

      Method setup_resources has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def setup_resources
    if datastore['UNCPATH'].blank?
      # Using WebDAV
      my_host = (datastore['SRVHOST'] == '0.0.0.0') ? Rex::Socket.source_address('50.50.50.50') : datastore['SRVHOST']
      @basename = rand_text_alpha(3)
      Severity: Minor
      Found in modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

        def on_request_uri(cli, request)
    case request.method
      when 'OPTIONS'
        process_options(cli, request)
      when 'PROPFIND'
      Severity: Major
      Found in modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb and 6 other locations - About 1 hr to fix
      modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 64..78
      modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 67..80
      modules/exploits/windows/http/cogent_datahub_command.rb on lines 64..77
      modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 61..74
      modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 59..72
      modules/exploits/windows/misc/wireshark_lua.rb on lines 62..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 10 locations. Consider refactoring.
      Open

        def process_options(cli, request)
    vprint_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
      Severity: Major
      Found in modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb and 9 other locations - About 50 mins to fix
      modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
      modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
      modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
      modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
      modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
      modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
      modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
      modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
      modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status