Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/smb/ms10_046_shortcut_icon_dllloader.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'            => 'Microsoft Windows Shell LNK Code Execution',
      'Description'    => %q{
          This module exploits a vulnerability in the handling of Windows
Severity: Minor
Found in modules/exploits/windows/smb/ms10_046_shortcut_icon_dllloader.rb - About 1 hr to fix

    Method generate_link has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def generate_link(unc)
    uni_unc = unc.unpack('C*').pack('v*')
    path = ''
    path << [
      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x6a, 0x00, 0x00, 0x00, 0x00,
    Severity: Minor
    Found in modules/exploits/windows/smb/ms10_046_shortcut_icon_dllloader.rb - About 1 hr to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

        def generate_link(unc)
    uni_unc = unc.unpack('C*').pack('v*')
    path = ''
    path << [
      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x6a, 0x00, 0x00, 0x00, 0x00,
      Severity: Major
      Found in modules/exploits/windows/smb/ms10_046_shortcut_icon_dllloader.rb and 3 other locations - About 7 hrs to fix
      modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb on lines 373..415
      modules/exploits/windows/fileformat/ms15_020_shortcut_icon_dllloader.rb on lines 115..158
      modules/exploits/windows/smb/ms15_020_shortcut_icon_dllloader.rb on lines 93..135

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 230.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status