Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/smb/webexec.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'WebExec Authenticated User Code Execution',
      'Description'    => %q{
        This module uses a valid username and password of any level (or
Severity: Minor
Found in modules/exploits/windows/smb/webexec.rb - About 1 hr to fix

    Method exploit has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    print_status("Connecting to the server...")
    connect

    print_status("Authenticating to #{smbhost} as user '#{splitname(datastore['SMBUser'])}'...")
    Severity: Minor
    Found in modules/exploits/windows/smb/webexec.rb - About 1 hr to fix

      Method report_auth has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def report_auth
    service_data = {
        address: ::Rex::Socket.getaddress(datastore['RHOST'],true),
        port: datastore['RPORT'],
        service_name: 'smb',
      Severity: Minor
      Found in modules/exploits/windows/smb/webexec.rb - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          def report_auth
    service_data = {
        address: ::Rex::Socket.getaddress(datastore['RHOST'],true),
        port: datastore['RPORT'],
        service_name: 'smb',
        Severity: Major
        Found in modules/exploits/windows/smb/webexec.rb and 1 other location - About 2 hrs to fix
        modules/exploits/windows/smb/psexec.rb on lines 154..195

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status