rapid7/metasploit-framework

View on GitHub
modules/exploits/windows/smtp/ms03_046_exchange2000_xexch50.rb

Summary

Maintainability
C
1 day
Test Coverage

Method exploit has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    bufflen = target['BuffLen']
    print_status("Trying to exploit #{target.name} with address 0x%.8x..." % target['Ret'])
    count = 1 # broke

Severity: Major
Found in modules/exploits/windows/smtp/ms03_046_exchange2000_xexch50.rb - About 2 hrs to fix

    Method exploit has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
        bufflen = target['BuffLen']
        print_status("Trying to exploit #{target.name} with address 0x%.8x..." % target['Ret'])
        count = 1 # broke
    
    
    Severity: Minor
    Found in modules/exploits/windows/smtp/ms03_046_exchange2000_xexch50.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
        super(update_info(info,
          'Name'           => 'MS03-046 Exchange 2000 XEXCH50 Heap Overflow',
          'Description'    => %q{
              This is an exploit for the Exchange 2000 heap overflow. Due
    Severity: Minor
    Found in modules/exploits/windows/smtp/ms03_046_exchange2000_xexch50.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
          connect
          banner = sock.get_once || ''
      
          if (banner !~ /Microsoft/)
      Severity: Minor
      Found in modules/exploits/windows/smtp/ms03_046_exchange2000_xexch50.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
          connect
          banner = sock.get_once || ''
      
          if (banner !~ /Microsoft/)
      Severity: Minor
      Found in modules/exploits/windows/smtp/ms03_046_exchange2000_xexch50.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status