Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/winrm/winrm_script_exec.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'WinRM Script Exec Remote Code Execution',
Severity: Minor
Found in modules/exploits/windows/winrm/winrm_script_exec.rb - About 1 hr to fix

    Method powershell2? has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def powershell2?
    if datastore['FORCE_VBS']
      print_status('User selected the FORCE_VBS option')
      return false
    end
    Severity: Minor
    Found in modules/exploits/windows/winrm/winrm_script_exec.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return true
    Severity: Major
    Found in modules/exploits/windows/winrm/winrm_script_exec.rb - About 30 mins to fix

      Method correct_payload_arch? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def correct_payload_arch?
    @target_arch = get_remote_arch
    case @target_arch
    when ARCH_X64
      unless datastore['PAYLOAD'].include?(ARCH_X64)
      Severity: Minor
      Found in modules/exploits/windows/winrm/winrm_script_exec.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status