Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/payloads/singles/cmd/mainframe/bind_shell_jcl.rb

Summary

Maintainability
D
2 days
Test Coverage

Method command_string has 247 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def command_string
    if (datastore['JOBNAME'] == "DUMMY") && !datastore['FTPUSER'].nil?
      datastore['JOBNAME'] = (datastore['FTPUSER'] + "1").strip.upcase
    end
    lhost = Rex::Socket.resolv_nbo(datastore['LHOST'])
Severity: Major
Found in modules/payloads/singles/cmd/mainframe/bind_shell_jcl.rb - About 1 day to fix

    File bind_shell_jcl.rb has 298 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module MetasploitModule
  CachedSize = 10712
  include Msf::Payload::Single
  include Msf::Payload::Mainframe
  include Msf::Sessions::CommandShellOptions
    Severity: Minor
    Found in modules/payloads/singles/cmd/mainframe/bind_shell_jcl.rb - About 3 hrs to fix

      Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(merge_info(info,
                     'Name'          => 'Z/OS (MVS) Command Shell, Bind TCP',
                     'Description'   => 'Provide JCL which creates a bind shell
                     This implementation does not include ebcdic character translation,
      Severity: Minor
      Found in modules/payloads/singles/cmd/mainframe/bind_shell_jcl.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def initialize(info = {})
    super(merge_info(info,
                     'Name'          => 'Z/OS (MVS) Command Shell, Bind TCP',
                     'Description'   => 'Provide JCL which creates a bind shell
                     This implementation does not include ebcdic character translation,
        Severity: Major
        Found in modules/payloads/singles/cmd/mainframe/bind_shell_jcl.rb and 1 other location - About 3 hrs to fix
        modules/payloads/singles/cmd/mainframe/reverse_shell_jcl.rb on lines 18..56

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status