Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/payloads/singles/osx/aarch64/shell_bind_tcp.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method generate has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def generate(_opts = {})
    # Split the cmd string into arg chunks
    cmd_str = datastore['CMD']
    cmd_and_args = Shellwords.shellsplit(cmd_str).map { |s| "#{s}\x00" }
Severity: Major
Found in modules/payloads/singles/osx/aarch64/shell_bind_tcp.rb - About 4 hrs to fix

    Method create_aarch64_string_in_stack has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create_aarch64_string_in_stack(string, registers: {})
    target = registers.fetch(:destination, :x0)
    stack = registers.fetch(:stack, :x9)

    # Instructions for pushing the bytes of the string 8 characters at a time
    Severity: Minor
    Found in modules/payloads/singles/osx/aarch64/shell_bind_tcp.rb - About 1 hr to fix

      Method create_aarch64_string_in_stack has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def create_aarch64_string_in_stack(string, registers: {})
    target = registers.fetch(:destination, :x0)
    stack = registers.fetch(:stack, :x9)

    # Instructions for pushing the bytes of the string 8 characters at a time
      Severity: Minor
      Found in modules/payloads/singles/osx/aarch64/shell_bind_tcp.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status